On 12/13/2010 10:07 PM, Pedro Alves wrote:
>> The second sentence is removed by this (2nd) patch, which depends on the
>> first patch.
> 
> I think it would have been easier if you had just posted this as
> an updated version of the first patch.
> 

OK, I combine them together in one single patch this time.

>> diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp
>> index 434dca4..373c450 100644
>> --- a/gdb/testsuite/gdb.python/py-section-script.exp
>> +++ b/gdb/testsuite/gdb.python/py-section-script.exp
>> @@ -17,7 +17,6 @@
>>  # scripts specified in the .debug_gdb_scripts section.
>>  
>>  # This test can only be run on targets which support ELF and use gas.
>> -# For now pick a sampling of likely targets.
>>  if {![istarget *-*-linux*]
>>      && ![istarget *-*-gnu*]
>>      && ![istarget *-*-elf*]
> 
> If the "support ELF" comment is correct (as opposed to "support DWARF-2" in
> the other cases), then you should not remove this one.
> 

Done.

> Back in the first patch:
> 
> On Sunday 05 December 2010 12:15:09, Yao Qi wrote:
>> +# This test can only be run on targets which support DWARF-2 and use gas.
>> +proc dwarf2_support {} {
> 
> There's no "This test" anymore.  Maybe:
> 
> # Return true if the target supports DWARF-2 and uses gas.
> # For now pick a sampling of likely targets.

Fixed.

-- 
Yao (齐尧)