From: Yao Qi <yao@codesourcery.com>
To: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [try 3rd] arm_pc_is_thumb takes displaced stepping into account
Date: Thu, 13 Jan 2011 16:34:00 -0000 [thread overview]
Message-ID: <4D2F24B9.6050509@codesourcery.com> (raw)
In-Reply-To: <1294931747.9907.137.camel@e102319-lin.cambridge.arm.com>
On 01/13/2011 09:15 AM, Matthew Gretton-Dann wrote:
> I agree with Ulrich, and prefer this latest patch to your previous ones
> - but I am still not 100% happy with it, as I think it would be better
> not to need anything from infrun.c at all here.
Agree. The perfect situation is that we need nothing from infrun.c in tdep.
> What could be done instead is to have the displaced stepping routines
> maintain a list of the areas of memory that are being used as scratch
> space, and the instruction set state of the instructions in those areas.
> Then arm_pc_is_thumb should check this list to see if the PC falls into
> one of these areas, and return the appropriate value.
That sounds good. Again, thanks for your inputs.
--
Yao Qi
next prev parent reply other threads:[~2011-01-13 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 7:50 [rfa] Update PC without side effect in displaced stepping Yao Qi
2010-12-20 8:06 ` Mark Kettenis
2010-12-20 13:42 ` Yao Qi
2010-12-21 16:19 ` Yao Qi
2010-12-23 4:54 ` Joel Brobecker
2010-12-23 8:45 ` Yao Qi
2011-01-06 14:19 ` [PING : rfa] " Yao Qi
2011-01-12 5:39 ` [try 3rd] arm_pc_is_thumb takes displaced stepping into account Yao Qi
2011-01-13 15:55 ` Matthew Gretton-Dann
2011-01-13 16:34 ` Yao Qi [this message]
2011-01-19 16:09 ` [Ping 1: try " Yao Qi
2011-01-30 3:21 ` [Ping 2: " Yao Qi
2011-01-31 15:40 ` [try " Ulrich Weigand
2011-02-10 6:42 ` Yao Qi
2011-02-15 21:15 ` Ulrich Weigand
2010-12-23 12:04 ` [rfa] Update PC without side effect in displaced stepping Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F24B9.6050509@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).