From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14504 invoked by alias); 31 Jan 2011 19:52:39 -0000 Received: (qmail 14492 invoked by uid 22791); 31 Jan 2011 19:52:38 -0000 X-SWARE-Spam-Status: No, hits=1.0 required=5.0 tests=AWL,BAYES_00,BOTNET,RDNS_NONE X-Spam-Check-By: sourceware.org Received: from Unknown (HELO mail3.caviumnetworks.com) (12.108.191.235) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 19:52:34 +0000 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Mon, 31 Jan 2011 11:53:23 -0800 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 31 Jan 2011 11:52:32 -0800 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 31 Jan 2011 11:52:32 -0800 Message-ID: <4D4712FB.8050708@caviumnetworks.com> Date: Mon, 31 Jan 2011 20:08:00 -0000 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: Michael Snyder Subject: Re: Ping: [Patch v2] Add mips*-linux* catch syscall support. References: <4D3DD73C.9060201@caviumnetworks.com> <4D46F658.3020302@caviumnetworks.com> <4D47116A.7080001@vmware.com> In-Reply-To: <4D47116A.7080001@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00594.txt.bz2 On 01/31/2011 11:45 AM, Michael Snyder wrote: > David Daney wrote: >> If it is not too much trouble, could a Maintainer review this patch? >> >> Thanks in advance, >> David Daney > > There's an off-by-one indentation here: > > > +static LONGEST > +mips_linux_get_syscall_number (struct gdbarch *gdbarch, > + ptid_t ptid) > Good catch. If approved, I would commit the corrected version. > Other than that, the part in mips-linux-tdep.c looks reasonable. > I don't understand the xml parts well enough to comment. > Thanks for looking at it, now to get someone to give the official 'OK' David Daney