From: Yao Qi <yao@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [try 3rd] arm_pc_is_thumb takes displaced stepping into account
Date: Thu, 10 Feb 2011 06:42:00 -0000 [thread overview]
Message-ID: <4D5388D6.2050901@codesourcery.com> (raw)
In-Reply-To: <201101311538.p0VFcwIn019533@d06av02.portsmouth.uk.ibm.com>
On 01/31/2011 11:38 PM, Ulrich Weigand wrote:
> What if the copy area contains more than a single instruction, and we
> need to find out the mode of the PC corresponding to the second of them?
>
This approach can handle multiple instructions in copy area, because
during preparation of displaced stepping (in displaced_step_prepare),
regcache_write_pc is called to update PC to the *address of copy area*,
no matter how many instructions in copy area.
Per my limited knowledge on GDB, I can't find a case that PC is set
somewhere of copy area other than the beginning of copy area during
displaced stepping. That is to say, we don't have to know the mode of
the 2nd instruction.
Actually, most of the time, copy area contains more than one
instructions, and test suite works well. This can also prove that this
approach works.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-02-10 6:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 7:50 [rfa] Update PC without side effect in displaced stepping Yao Qi
2010-12-20 8:06 ` Mark Kettenis
2010-12-20 13:42 ` Yao Qi
2010-12-21 16:19 ` Yao Qi
2010-12-23 4:54 ` Joel Brobecker
2010-12-23 8:45 ` Yao Qi
2011-01-06 14:19 ` [PING : rfa] " Yao Qi
2011-01-12 5:39 ` [try 3rd] arm_pc_is_thumb takes displaced stepping into account Yao Qi
2011-01-13 15:55 ` Matthew Gretton-Dann
2011-01-13 16:34 ` Yao Qi
2011-01-19 16:09 ` [Ping 1: try " Yao Qi
2011-01-30 3:21 ` [Ping 2: " Yao Qi
2011-01-31 15:40 ` [try " Ulrich Weigand
2011-02-10 6:42 ` Yao Qi [this message]
2011-02-15 21:15 ` Ulrich Weigand
2010-12-23 12:04 ` [rfa] Update PC without side effect in displaced stepping Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5388D6.2050901@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).