* [patch] Skip async-shell.exp if displaced stepping is not supported
@ 2011-07-13 7:09 Yao Qi
2011-07-13 14:28 ` Tom Tromey
0 siblings, 1 reply; 6+ messages in thread
From: Yao Qi @ 2011-07-13 7:09 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 137 bytes --]
non-stop mode needs displaced stepping. Skip this test on the target
which displaced stepping is not supported.
--
Yao (é½å°§)
[-- Attachment #2: 0012-skip-async-shell-if-disp-step-is-not-supported.patch --]
[-- Type: text/x-patch, Size: 782 bytes --]
2011-07-13 Yao Qi <yao@codesourcery.com>
gdb/testsuite/
* gdb.base/async-shell.exp: Skip test if displaced stepping is not
supported.
---
gdb/testsuite/gdb.base/async-shell.exp | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/gdb/testsuite/gdb.base/async-shell.exp b/gdb/testsuite/gdb.base/async-shell.exp
index b5ccd1f..a1eb314 100644
--- a/gdb/testsuite/gdb.base/async-shell.exp
+++ b/gdb/testsuite/gdb.base/async-shell.exp
@@ -14,6 +14,12 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
set testfile async-shell
+
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
return -1
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Skip async-shell.exp if displaced stepping is not supported
2011-07-13 7:09 [patch] Skip async-shell.exp if displaced stepping is not supported Yao Qi
@ 2011-07-13 14:28 ` Tom Tromey
2011-07-14 17:25 ` Yao Qi
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2011-07-13 14:28 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2011-07-13 Yao Qi <yao@codesourcery.com>
Yao> gdb/testsuite/
Yao> * gdb.base/async-shell.exp: Skip test if displaced stepping is not
Yao> supported.
Ok.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Skip async-shell.exp if displaced stepping is not supported
2011-07-13 14:28 ` Tom Tromey
@ 2011-07-14 17:25 ` Yao Qi
2011-07-14 22:26 ` Tom Tromey
0 siblings, 1 reply; 6+ messages in thread
From: Yao Qi @ 2011-07-14 17:25 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On 07/13/2011 09:33 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> 2011-07-13 Yao Qi <yao@codesourcery.com>
> Yao> gdb/testsuite/
> Yao> * gdb.base/async-shell.exp: Skip test if displaced stepping is not
> Yao> supported.
>
> Ok.
>
Thanks, Tom. When I was going to check in, I find there are other test
cases on non-stop should be skipped in the same way. Patch here is to
skip them in the same way.
OK ?
--
Yao (é½å°§)
[-- Attachment #2: mi_non_stop_disp_step.patch --]
[-- Type: text/x-patch, Size: 3881 bytes --]
gdb/testsuite/
2011-07-14 Yao Qi <yao@codesourcery.com>
* gdb.mi/mi-nonstop-exit.exp: Skip test if displaced stepping is not
supported.
* gdb.mi/mi-nonstop.exp: Likewise.
* gdb.mi/mi-ns-stale-regcache.exp: Likewise.
* gdb.mi/mi-nsintrall.exp: Likewise.
* gdb.mi/mi-nsmoribund.exp: Likewise.
* gdb.mi/mi-nsthrexec.exp: Likewise.
* gdb.python/py-evthreads.exp: Likewise.
diff --git a/gdb/testsuite/gdb.mi/mi-nonstop-exit.exp b/gdb/testsuite/gdb.mi/mi-nonstop-exit.exp
index b2e4948..8493b4c 100644
--- a/gdb/testsuite/gdb.mi/mi-nonstop-exit.exp
+++ b/gdb/testsuite/gdb.mi/mi-nonstop-exit.exp
@@ -13,6 +13,11 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.mi/mi-nonstop.exp b/gdb/testsuite/gdb.mi/mi-nonstop.exp
index cb69c2d..ec88f02 100644
--- a/gdb/testsuite/gdb.mi/mi-nonstop.exp
+++ b/gdb/testsuite/gdb.mi/mi-nonstop.exp
@@ -14,6 +14,12 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp b/gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp
index e760a2d..b8d5e4f 100644
--- a/gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp
+++ b/gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp
@@ -17,6 +17,11 @@
# Regression test for PR11557. Make sure we don't end up with a stale
# register cache just after resuming a thread.
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.mi/mi-nsintrall.exp b/gdb/testsuite/gdb.mi/mi-nsintrall.exp
index 6e1290a..046063b 100644
--- a/gdb/testsuite/gdb.mi/mi-nsintrall.exp
+++ b/gdb/testsuite/gdb.mi/mi-nsintrall.exp
@@ -13,6 +13,11 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
index 33b1ac3..1bf8920 100644
--- a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
+++ b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
@@ -13,6 +13,11 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.mi/mi-nsthrexec.exp b/gdb/testsuite/gdb.mi/mi-nsthrexec.exp
index ccb0edb..06dd1d9 100644
--- a/gdb/testsuite/gdb.mi/mi-nsthrexec.exp
+++ b/gdb/testsuite/gdb.mi/mi-nsthrexec.exp
@@ -23,6 +23,11 @@ if { [is_remote target] } then {
continue
}
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
diff --git a/gdb/testsuite/gdb.python/py-evthreads.exp b/gdb/testsuite/gdb.python/py-evthreads.exp
index 6ea7eb4..3ec6857 100644
--- a/gdb/testsuite/gdb.python/py-evthreads.exp
+++ b/gdb/testsuite/gdb.python/py-evthreads.exp
@@ -22,6 +22,11 @@ if $tracelevel then {
strace $tracelevel
}
+if { ![support_displaced_stepping] } {
+ unsupported "displaced stepping"
+ return -1
+}
+
load_lib gdb-python.exp
set testfile "py-evthreads"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Skip async-shell.exp if displaced stepping is not supported
2011-07-14 17:25 ` Yao Qi
@ 2011-07-14 22:26 ` Tom Tromey
2011-07-15 2:11 ` Jan Kratochvil
2011-07-18 15:01 ` [committed] " Yao Qi
0 siblings, 2 replies; 6+ messages in thread
From: Tom Tromey @ 2011-07-14 22:26 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2011-07-14 Yao Qi <yao@codesourcery.com>
Yao> * gdb.mi/mi-nonstop-exit.exp: Skip test if displaced stepping is not
Yao> supported.
Yao> * gdb.mi/mi-nonstop.exp: Likewise.
Yao> * gdb.mi/mi-ns-stale-regcache.exp: Likewise.
Yao> * gdb.mi/mi-nsintrall.exp: Likewise.
Yao> * gdb.mi/mi-nsmoribund.exp: Likewise.
Yao> * gdb.mi/mi-nsthrexec.exp: Likewise.
Yao> * gdb.python/py-evthreads.exp: Likewise.
Ok.
I had thought that the py-evthreads.exp test was changed not to rely on
non-stop, but I must have been mistaken.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Skip async-shell.exp if displaced stepping is not supported
2011-07-14 22:26 ` Tom Tromey
@ 2011-07-15 2:11 ` Jan Kratochvil
2011-07-18 15:01 ` [committed] " Yao Qi
1 sibling, 0 replies; 6+ messages in thread
From: Jan Kratochvil @ 2011-07-15 2:11 UTC (permalink / raw)
To: Tom Tromey; +Cc: Yao Qi, gdb-patches
On Thu, 14 Jul 2011 19:57:35 +0200, Tom Tromey wrote:
> >>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
> Yao> 2011-07-14 Yao Qi <yao@codesourcery.com>
> Yao> * gdb.python/py-evthreads.exp: Likewise.
[...]
> I had thought that the py-evthreads.exp test was changed not to rely on
> non-stop, but I must have been mistaken.
It still relies on non-stop. More discussed is at filed PR:
event.inferior_thread does not exist in all-stop/sync mode
http://sourceware.org/bugzilla/show_bug.cgi?id=12967
Thanks,
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [committed] [patch] Skip async-shell.exp if displaced stepping is not supported
2011-07-14 22:26 ` Tom Tromey
2011-07-15 2:11 ` Jan Kratochvil
@ 2011-07-18 15:01 ` Yao Qi
1 sibling, 0 replies; 6+ messages in thread
From: Yao Qi @ 2011-07-18 15:01 UTC (permalink / raw)
To: gdb-patches
On 07/15/2011 01:57 AM, Tom Tromey wrote:
> Yao> 2011-07-14 Yao Qi <yao@codesourcery.com>
> Yao> * gdb.mi/mi-nonstop-exit.exp: Skip test if displaced stepping is not
> Yao> supported.
> Yao> * gdb.mi/mi-nonstop.exp: Likewise.
> Yao> * gdb.mi/mi-ns-stale-regcache.exp: Likewise.
> Yao> * gdb.mi/mi-nsintrall.exp: Likewise.
> Yao> * gdb.mi/mi-nsmoribund.exp: Likewise.
> Yao> * gdb.mi/mi-nsthrexec.exp: Likewise.
> Yao> * gdb.python/py-evthreads.exp: Likewise.
>
> Ok.
Thanks for the review. Committed.
http://sourceware.org/ml/gdb-cvs/2011-07/msg00157.html
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-18 4:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-13 7:09 [patch] Skip async-shell.exp if displaced stepping is not supported Yao Qi
2011-07-13 14:28 ` Tom Tromey
2011-07-14 17:25 ` Yao Qi
2011-07-14 22:26 ` Tom Tromey
2011-07-15 2:11 ` Jan Kratochvil
2011-07-18 15:01 ` [committed] " Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).