From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 81175382E83F for ; Mon, 22 Feb 2021 08:28:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 81175382E83F Received: by mail-wr1-x431.google.com with SMTP id h98so13279005wrh.11 for ; Mon, 22 Feb 2021 00:28:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J7IEkOZWpknZEa8Gf+VEsoZnchsZzWSDnhce5IJhXxA=; b=kVH9f3QlJYKoyCorrajZ3pWJKD+3X51dkwKf60WquxnuAoqolBYEbVn0+r/xq6exvd IYLJV1MtBnPsst1Km7+iaXWQmy+sV6WNeHICQY8f38DobPap+pYnwJnv4AjJtOo5LgRh BHK69R9qgX8OxmA2DcFrgM3ElCys36iLmtdn48HjN7HQ0Hy2e33aktepxMt5Ymn7zo1L R5gaLq/0muS+d1dZ7NkSTMhbvbuV76afB+lYEFHkcEskpfwz9XIXlpnBjoo8YF/gBtUe jqdZJOCa1MamAUrIAYea6rikmdIV4aAatpY6YYCSSANH6aLhqJC3JhVy05F1BQjRh0UX oBPA== X-Gm-Message-State: AOAM533L5Xb66vJuOyQZQ6Hc4g7a2XJRSrnBuLUfhedqYC72/OScmvP3 2oBtU9UXH4Prz/Mnis0x99L+nu9vOcjiQTm07WBAYuedhrzb2mxxUwtOmy0zoky4TSSVFoYjYaT u1W3KfsWoc6ED1MeL4wPqJIj7/LqxLDKjPysrVjRngnyK6ZgY7dKzeyHER4KhQPEv8Tm3Nt2aiQ == X-Google-Smtp-Source: ABdhPJxznomJikgzV+mqzkqhhDZfTavcxOJMzTMOMqYhA2dz4gy8pgSBj8J9WBWfkXclwX6+MTLOrA== X-Received: by 2002:a05:6000:c1:: with SMTP id q1mr21001534wrx.114.1613982530272; Mon, 22 Feb 2021 00:28:50 -0800 (PST) Received: from [192.168.0.103] (cpc159317-cmbg20-2-0-cust151.5-4.cable.virginm.net. [81.111.29.152]) by smtp.gmail.com with ESMTPSA id y12sm16070045wrm.33.2021.02.22.00.28.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Feb 2021 00:28:49 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: [PING 3] [PATCH v2 0/5] Add support for command renaming From: Marco Barisione In-Reply-To: Date: Mon, 22 Feb 2021 08:28:47 +0000 Content-Transfer-Encoding: 7bit Message-Id: <4E618E8D-B469-4353-998F-A25051372D15@undo.io> References: <20210108100706.96190-1-mbarisione@undo.io> <20210125112649.56362-1-mbarisione@undo.io> To: GDB patches mailing list X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 08:28:53 -0000 Ping. > On 15 Feb 2021, at 08:27, Marco Barisione wrote: > > Ping. > > On Mon, 8 Feb 2021 at 17:53, Marco Barisione wrote: >> >> Ping. >> >> On Mon, 25 Jan 2021 at 11:26, Marco Barisione wrote: >>> This patch series adds support for command renaming to GDB. See the >>> first email of this thread for details on the rationale and design. >>> >>> This second version fixes a few style issues, a bug in my code, and the >>> way the prefix name for prefix commands is set. In particular: >>> * Patch 1: add lookup_cmd_exact to simplify a common pattern >>> Same as before except for style fixes. >>> * Patch 2: prevent prefix commands from being hooks >>> Same as before. >>> * Patch 3: update the docs for add_cmd and do_add_cmd to match reality >>> Same as before. >>> * Patch 4: generate the prefix name for prefix commands on demand >>> New patch which changes how the prefix name is set/generated. >>> This simplifies a lot of existing code and the code from the next >>> patch. Moreover, it fixes what I think could lead to a use after >>> free (based on reading code, I didn't actually reproduce any crash). >>> * Patch 5: Add support for renaming commands >>> Updated version of what was before patch 4. >>> This contains a few style fixes and makes delete_cmd_by_name use >>> the lookup_cmd_exact function rather than find_cmd. >>> >>> Note that patches 1 to 4 are needed for the new feature but could be >>> merged separately as they are improvements to the existing code. >>> >>> Marco Barisione (5): >>> gdb: add lookup_cmd_exact to simplify a common pattern >>> gdb: prevent prefix commands from being hooks >>> gdb: update the docs for add_cmd and do_add_cmd to match reality >>> gdb: generate the prefix name for prefix commands on demand >>> gdb: Add support for renaming commands >>> >>> gdb/NEWS | 26 + >>> gdb/ada-lang.c | 8 +- >>> gdb/arm-tdep.c | 4 +- >>> gdb/auto-load.c | 9 +- >>> gdb/breakpoint.c | 20 +- >>> gdb/bsd-kvm.c | 2 +- >>> gdb/btrace.c | 9 +- >>> gdb/cli/cli-cmds.c | 12 +- >>> gdb/cli/cli-decode.c | 731 ++++++++++++++---- >>> gdb/cli/cli-decode.h | 29 +- >>> gdb/cli/cli-dump.c | 16 +- >>> gdb/cli/cli-logging.c | 4 +- >>> gdb/cli/cli-script.c | 375 +++++++-- >>> gdb/cli/cli-setshow.c | 11 +- >>> gdb/cli/cli-style.c | 11 +- >>> gdb/cli/cli-style.h | 3 - >>> gdb/command.h | 110 ++- >>> gdb/compile/compile.c | 2 +- >>> gdb/cp-support.c | 1 - >>> gdb/dcache.c | 5 +- >>> gdb/doc/gdb.texinfo | 55 +- >>> gdb/doc/python.texi | 38 +- >>> gdb/dwarf2/index-cache.c | 4 +- >>> gdb/dwarf2/read.c | 4 +- >>> gdb/f-lang.c | 4 +- >>> gdb/frame.c | 4 +- >>> gdb/gnu-nat.c | 12 +- >>> gdb/go32-nat.c | 2 +- >>> gdb/guile/guile.c | 9 +- >>> gdb/guile/scm-cmd.c | 2 +- >>> gdb/i386-tdep.c | 4 +- >>> gdb/infcmd.c | 8 +- >>> gdb/language.c | 4 +- >>> gdb/macrocmd.c | 2 +- >>> gdb/maint-test-options.c | 3 +- >>> gdb/maint-test-settings.c | 2 - >>> gdb/maint.c | 18 +- >>> gdb/memattr.c | 4 +- >>> gdb/mips-tdep.c | 6 +- >>> gdb/printcmd.c | 2 +- >>> gdb/probe.c | 3 +- >>> gdb/python/py-cmd.c | 228 ++++-- >>> gdb/python/python-internal.h | 1 + >>> gdb/python/python.c | 6 +- >>> gdb/ravenscar-thread.c | 4 +- >>> gdb/record-btrace.c | 16 +- >>> gdb/record-full.c | 6 +- >>> gdb/record.c | 10 +- >>> gdb/remote.c | 6 +- >>> gdb/riscv-tdep.c | 8 +- >>> gdb/rs6000-tdep.c | 4 +- >>> gdb/ser-tcp.c | 4 +- >>> gdb/serial.c | 4 +- >>> gdb/sh-tdep.c | 4 +- >>> gdb/skip.c | 2 +- >>> gdb/sparc64-tdep.c | 2 +- >>> gdb/stack.c | 8 +- >>> gdb/symfile.c | 2 +- >>> gdb/symtab.c | 3 +- >>> gdb/target-descriptions.c | 6 +- >>> gdb/target.c | 2 +- >>> gdb/testsuite/gdb.base/command-renaming.exp | 571 ++++++++++++++ >>> gdb/testsuite/gdb.base/define-prefix.exp | 24 + >>> .../gdb.python/py-rename-existing.exp | 364 +++++++++ >>> .../gdb.python/py-rename-existing.py | 46 ++ >>> gdb/thread.c | 4 +- >>> gdb/top.c | 10 +- >>> gdb/tracepoint.c | 2 +- >>> gdb/tui/tui-layout.c | 2 +- >>> gdb/tui/tui-win.c | 8 +- >>> gdb/typeprint.c | 6 +- >>> gdb/unittests/command-def-selftests.c | 4 +- >>> gdb/utils.c | 4 - >>> gdb/valprint.c | 10 +- >>> gdb/value.c | 2 +- >>> gdb/windows-tdep.c | 2 +- >>> 76 files changed, 2434 insertions(+), 529 deletions(-) >>> create mode 100644 gdb/testsuite/gdb.base/command-renaming.exp >>> create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.exp >>> create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.py >>> >>> -- >>> 2.28.0 >>> -- Marco Barisione