From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85183-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12383 invoked by alias); 14 Nov 2011 18:04:06 -0000
Received: (qmail 12366 invoked by uid 22791); 14 Nov 2011 18:04:04 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 18:03:38 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAEI3bZO016274	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 14 Nov 2011 13:03:37 -0500
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAEI3Yxs028826	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Mon, 14 Nov 2011 13:03:36 -0500
Message-ID: <4EC157F6.1030503@redhat.com>
Date: Mon, 14 Nov 2011 18:04:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] mi/10586
References: <4EBD93D9.2020006@redhat.com> <m3mxbyso6i.fsf@fleche.redhat.com>
In-Reply-To: <m3mxbyso6i.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00360.txt.bz2

On 11/14/2011 07:45 AM, Tom Tromey wrote:

> ChangeLog should mention the PR.

That would be useful, no? I don't know why I sometimes forget. I've 
added that.

> Keith>  +	type_name = TYPE_FIELD_NAME (type, index);
> Keith>  +	if (*type_name == '\0')
> Keith>  +	  name = xstrprintf ("anonymous%d", index);
> Keith>  +	else
> Keith>  +	  name = type_name;
>
> What happens if there is a clash between a named field's name and the
> generated name for an anonymous field?

Ha. My guess: bad things (TM).

Given that variables cannot start with numbers, I've changed the name 
string to "%d_anonymous".

Other comments?
Keith