* [patch] print debug message for static tracepoint
@ 2012-01-04 4:01 Yao Qi
2012-01-04 12:05 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2012-01-04 4:01 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
Hi,
Looks we don't consider static tracepoint type when printing debug
message in cmd_qtdp. With this patch, we can print tracepoint types for
fast/regular/static tracepoint.
It is sort of obvious, but review is welcome.
--
Yao (é½å°§)
[-- Attachment #2: 0005-print-dbg-msg-for-static-tp.patch --]
[-- Type: text/x-patch, Size: 769 bytes --]
2012-01-04 Yao Qi <yao@codesourcery.com>
* tracepoint.c (cmd_qtdp): Print debug message
for static tracepoint.
---
gdb/gdbserver/tracepoint.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index 103a17d..9534105 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -2441,7 +2441,7 @@ cmd_qtdp (char *own_buf)
trace_debug ("Defined %stracepoint %d at 0x%s, "
"enabled %d step %ld pass %ld",
tpoint->type == fast_tracepoint ? "fast "
- : "",
+ : tpoint->type == static_tracepoint ? "static " : "",
tpoint->number, paddress (tpoint->address), tpoint->enabled,
tpoint->step_count, tpoint->pass_count);
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] print debug message for static tracepoint
2012-01-04 4:01 [patch] print debug message for static tracepoint Yao Qi
@ 2012-01-04 12:05 ` Pedro Alves
2012-01-04 14:41 ` [committed]: " Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2012-01-04 12:05 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 01/04/2012 04:00 AM, Yao Qi wrote:
> Hi,
> Looks we don't consider static tracepoint type when printing debug
> message in cmd_qtdp. With this patch, we can print tracepoint types for
> fast/regular/static tracepoint.
>
> It is sort of obvious, but review is welcome.
>
Yeah. Okay.
--
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* [committed]: [patch] print debug message for static tracepoint
2012-01-04 12:05 ` Pedro Alves
@ 2012-01-04 14:41 ` Yao Qi
0 siblings, 0 replies; 3+ messages in thread
From: Yao Qi @ 2012-01-04 14:41 UTC (permalink / raw)
Cc: gdb-patches
On 01/04/2012 08:04 PM, Pedro Alves wrote:
> On 01/04/2012 04:00 AM, Yao Qi wrote:
>> Hi,
>> Looks we don't consider static tracepoint type when printing debug
>> message in cmd_qtdp. With this patch, we can print tracepoint types for
>> fast/regular/static tracepoint.
>>
>> It is sort of obvious, but review is welcome.
>>
>
> Yeah. Okay.
>
Thanks, Pedro. Committed.
http://sourceware.org/ml/gdb-cvs/2012-01/msg00046.html
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-04 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-04 4:01 [patch] print debug message for static tracepoint Yao Qi
2012-01-04 12:05 ` Pedro Alves
2012-01-04 14:41 ` [committed]: " Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).