From: xgsa <xgsa@yandex.ru>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: RTTI type improvement for (was: "Re: set print object on should affect MI varobjs (PR mi/13393)")
Date: Fri, 06 Jan 2012 15:47:00 -0000 [thread overview]
Message-ID: <4F07177C.5080201@yandex.ru> (raw)
In-Reply-To: <20120102022153.GA686@host2.jankratochvil.net>
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
> That change to value_rtti_indirect_type would be easier to read if it was
> a separate patch.
This is the first part of my previous patch that contains the change
to value_rtti_indirect_type. The second part requires this one to be
applied, so I'll provide it after commit.
Here is an example of what this patch fixes:
struct Base {
virtual ~Base() {}
};
struct Derived: public Base {};
int main()
{
Derived i;
const Base& ri = i;
const Base* pi = &i;
return 0; // <= run until this line
}
The "whatis ri" command fails with message:
"Attempt to take contents of a non-pointer value.".
The "whatis pi" command does not respect cv-qualifiers:
type = /* real type = Derived * */
const Base *
This patch fixes these problems and takes into account the last Jan's review.
gdb/ChangeLog:
2012-01-06 Anton Gorenkov <xgsa@yandex.ru>
* c-valprint.c (c_value_print): Use value_rtti_indirect_type
instead of value_rtti_target_type.
* eval.c (evaluate_subexp_standard): Use value_rtti_indirect_type
instead of value_rtti_target_type.
* typeprint.c (whatis_exp): Use value_rtti_indirect_type instead of
value_rtti_target_type.
* valops.c (value_ind): Extract function readjust_indirect_value_type.
(value_rtti_indirect_type): The replacement for value_rtti_target_type.
* value.c (readjust_indirect_value_type): New function.
(coerce_ref): Support for enclosing type setting for references
with readjust_indirect_value_type.
* value.h (readjust_value_type): The replacement for
value_rtti_target_type.
[-- Attachment #2: gdb_reference_rtti_fix1.patch --]
[-- Type: text/x-diff, Size: 8332 bytes --]
diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c
index 3461b08..e2e2792 100644
--- a/gdb/c-valprint.c
+++ b/gdb/c-valprint.c
@@ -698,22 +698,13 @@ c_value_print (struct value *val, struct ui_file *stream,
if (value_entirely_available (val))
{
- real_type = value_rtti_target_type (val, &full, &top, &using_enc);
+ real_type = value_rtti_indirect_type (val, &full, &top,
+ &using_enc);
if (real_type)
{
/* RTTI entry found. */
- if (TYPE_CODE (type) == TYPE_CODE_PTR)
- {
- /* Create a pointer type pointing to the real
- type. */
- type = lookup_pointer_type (real_type);
- }
- else
- {
- /* Create a reference type referencing the real
- type. */
- type = lookup_reference_type (real_type);
- }
+ type = real_type;
+
/* Need to adjust pointer value. */
val = value_from_pointer (type, value_as_address (val) - top);
diff --git a/gdb/eval.c b/gdb/eval.c
index 5d758d1..10606a8 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -1990,16 +1990,10 @@ evaluate_subexp_standard (struct type *expect_type,
if (opts.objectprint && TYPE_TARGET_TYPE(type)
&& (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS))
{
- real_type = value_rtti_target_type (arg1, &full, &top, &using_enc);
+ real_type = value_rtti_indirect_type (arg1, &full, &top,
+ &using_enc);
if (real_type)
- {
- if (TYPE_CODE (type) == TYPE_CODE_PTR)
- real_type = lookup_pointer_type (real_type);
- else
- real_type = lookup_reference_type (real_type);
-
arg1 = value_cast (real_type, arg1);
- }
}
}
diff --git a/gdb/typeprint.c b/gdb/typeprint.c
index cf4158d..6546c98 100644
--- a/gdb/typeprint.c
+++ b/gdb/typeprint.c
@@ -140,16 +140,7 @@ whatis_exp (char *exp, int show)
if (((TYPE_CODE (type) == TYPE_CODE_PTR)
|| (TYPE_CODE (type) == TYPE_CODE_REF))
&& (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS))
- {
- real_type = value_rtti_target_type (val, &full, &top, &using_enc);
- if (real_type)
- {
- if (TYPE_CODE (type) == TYPE_CODE_PTR)
- real_type = lookup_pointer_type (real_type);
- else
- real_type = lookup_reference_type (real_type);
- }
- }
+ real_type = value_rtti_indirect_type (val, &full, &top, &using_enc);
else if (TYPE_CODE (type) == TYPE_CODE_CLASS)
real_type = value_rtti_type (val, &full, &top, &using_enc);
}
diff --git a/gdb/valops.c b/gdb/valops.c
index cb39677..2bc02f3 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1774,15 +1774,7 @@ value_ind (struct value *arg1)
(value_as_address (arg1)
- value_pointed_to_offset (arg1)));
- /* Re-adjust type. */
- deprecated_set_value_type (arg2, TYPE_TARGET_TYPE (base_type));
- /* Add embedding info. */
- set_value_enclosing_type (arg2, enc_type);
- set_value_embedded_offset (arg2, value_pointed_to_offset (arg1));
-
- /* We may be pointing to an object of some derived type. */
- arg2 = value_full_object (arg2, NULL, 0, 0, 0);
- return arg2;
+ return readjust_indirect_value_type (arg2, enc_type, base_type, arg1);
}
error (_("Attempt to take contents of a non-pointer value."));
@@ -3528,21 +3520,48 @@ value_maybe_namespace_elt (const struct type *curtype,
return result;
}
-/* Given a pointer value V, find the real (RTTI) type of the object it
- points to.
+/* Given a pointer or a reference value V, find its real (RTTI) type.
Other parameters FULL, TOP, USING_ENC as with value_rtti_type()
and refer to the values computed for the object pointed to. */
struct type *
-value_rtti_target_type (struct value *v, int *full,
- int *top, int *using_enc)
+value_rtti_indirect_type (struct value *v, int *full,
+ int *top, int *using_enc)
{
struct value *target;
+ struct type *type, *real_type, *target_type;
+
+ type = value_type (v);
+ type = check_typedef (type);
+ if (TYPE_CODE (type) == TYPE_CODE_REF)
+ target = coerce_ref (v);
+ else if (TYPE_CODE (type) == TYPE_CODE_PTR)
+ target = value_ind (v);
+ else
+ return NULL;
- target = value_ind (v);
+ real_type = value_rtti_type (target, full, top, using_enc);
+
+ if (real_type)
+ {
+ /* Copy qualifiers to the referenced object. */
+ target_type = value_type (target);
+ real_type = make_cv_type (TYPE_CONST (target_type),
+ TYPE_VOLATILE (target_type), real_type, NULL);
+ if (TYPE_CODE (type) == TYPE_CODE_REF)
+ real_type = lookup_reference_type (real_type);
+ else if (TYPE_CODE (type) == TYPE_CODE_PTR)
+ real_type = lookup_pointer_type (real_type);
+ else
+ internal_error (__FILE__, __LINE__, _("Unexpected value type."));
+
+ /* Copy qualifiers to the pointer/reference. */
+ real_type = make_cv_type (TYPE_CONST (type), TYPE_VOLATILE (type),
+ real_type, NULL);
+ }
- return value_rtti_type (target, full, top, using_enc);
+ return real_type;
}
/* Given a value pointed to by ARGP, check its real run-time type, and
diff --git a/gdb/value.c b/gdb/value.c
index d263d0c..c78e489 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3109,11 +3109,30 @@ coerce_ref_if_computed (const struct value *arg)
return funcs->coerce_ref (arg);
}
+/* Look at value.h for description. */
+
+struct value *
+readjust_indirect_value_type (struct value *value, struct type *enc_type,
+ struct type *original_type,
+ struct value *original_value)
+{
+ /* Re-adjust type. */
+ deprecated_set_value_type (value, TYPE_TARGET_TYPE (original_type));
+
+ /* Add embedding info. */
+ set_value_enclosing_type (value, enc_type);
+ set_value_embedded_offset (value, value_pointed_to_offset (original_value));
+
+ /* We may be pointing to an object of some derived type. */
+ return value_full_object (value, NULL, 0, 0, 0);
+}
+
struct value *
coerce_ref (struct value *arg)
{
struct type *value_type_arg_tmp = check_typedef (value_type (arg));
struct value *retval;
+ struct type *enc_type;
retval = coerce_ref_if_computed (arg);
if (retval)
@@ -3122,9 +3141,13 @@ coerce_ref (struct value *arg)
if (TYPE_CODE (value_type_arg_tmp) != TYPE_CODE_REF)
return arg;
- return value_at_lazy (TYPE_TARGET_TYPE (value_type_arg_tmp),
- unpack_pointer (value_type (arg),
- value_contents (arg)));
+ enc_type = check_typedef (value_enclosing_type (arg));
+ enc_type = TYPE_TARGET_TYPE (enc_type);
+
+ retval = value_at_lazy (enc_type,
+ unpack_pointer (value_type (arg),
+ value_contents (arg)));
+ return readjust_indirect_value_type (retval, enc_type, value_type_arg_tmp, arg);
}
struct value *
diff --git a/gdb/value.h b/gdb/value.h
index d2c58ec..679192f 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -353,6 +353,19 @@ extern short *deprecated_value_regnum_hack (struct value *);
extern struct value *coerce_ref_if_computed (const struct value *arg);
+/* Setup a new value type and enclosing value type for dereferenced value VALUE.
+ ENC_TYPE is the new enclosing type that should be set. ORIGINAL_TYPE and
+ ORIGINAL_VALUE are the type and value of the original reference or pointer.
+
+ Note, that VALUE is modified by this function.
+
+ It is a common implementation for coerce_ref and value_ind. */
+
+extern struct value *
+readjust_indirect_value_type (struct value *value, struct type *enc_type,
+ struct type *original_type,
+ struct value *original_value);
+
/* Convert a REF to the object referenced. */
extern struct value *coerce_ref (struct value *value);
@@ -617,8 +630,8 @@ extern struct value *value_primitive_field (struct value *arg1, int offset,
struct type *arg_type);
-extern struct type *value_rtti_target_type (struct value *, int *, int *,
- int *);
+extern struct type *value_rtti_indirect_type (struct value *, int *, int *,
+ int *);
extern struct value *value_full_object (struct value *, struct type *, int,
int, int);
next prev parent reply other threads:[~2012-01-06 15:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 19:50 set print object on should affect MI varobjs (PR 13393) xgsa
2011-12-08 8:15 ` xgsa
2011-12-19 20:34 ` xgsa
2011-12-20 17:47 ` Tom Tromey
2011-12-21 19:01 ` set print object on should affect MI varobjs (PR gdb/13393) xgsa
2011-12-21 19:37 ` Jan Kratochvil
2011-12-22 10:17 ` set print object on should affect MI varobjs (PR mi/13393) xgsa
2011-12-24 1:55 ` Jan Kratochvil
2011-12-24 13:56 ` xgsa
2012-01-02 2:22 ` Jan Kratochvil
2012-01-06 15:47 ` xgsa [this message]
2012-01-09 14:41 ` RTTI type improvement for (was: "Re: set print object on should affect MI varobjs (PR mi/13393)") Jan Kratochvil
2012-01-11 21:58 ` RTTI type improvement for Tom Tromey
2012-01-12 11:25 ` xgsa
2012-02-06 21:45 ` Tom Tromey
2012-02-08 18:34 ` xgsa
2012-02-10 20:13 ` Tom Tromey
2012-02-19 18:46 ` set print object on should affect MI varobjs (PR mi/13393) xgsa
2012-02-23 4:58 ` xgsa
2012-03-18 16:28 ` xgsa
2012-03-18 20:41 ` Eli Zaretskii
2012-03-19 7:10 ` xgsa
2012-03-19 17:41 ` Eli Zaretskii
2012-03-23 17:09 ` xgsa
2012-03-26 19:08 ` xgsa
2012-03-30 17:51 ` Tom Tromey
2012-03-30 18:01 ` Eli Zaretskii
2012-03-30 20:11 ` xgsa
2012-03-30 18:01 ` Eli Zaretskii
2012-03-30 20:25 ` xgsa
2012-03-30 20:52 ` Eli Zaretskii
2012-03-30 21:26 ` xgsa
2012-03-31 5:54 ` Eli Zaretskii
2012-03-31 6:57 ` xgsa
2012-03-31 9:33 ` xgsa
2012-04-03 0:54 ` Doug Evans
2012-04-03 13:27 ` xgsa
2012-04-06 17:11 ` xgsa
2012-04-13 8:07 ` xgsa
2012-04-13 12:22 ` Eli Zaretskii
2012-04-13 12:34 ` xgsa
2012-04-13 17:23 ` Tom Tromey
2012-04-14 23:35 ` xgsa
2012-04-16 18:35 ` Jan Kratochvil
2012-07-23 17:21 ` Ulrich Weigand
2012-08-06 7:26 ` xgsa
2012-02-21 14:15 ` RTTI type improvement for xgsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F07177C.5080201@yandex.ru \
--to=xgsa@yandex.ru \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).