From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints
Date: Tue, 10 Jan 2012 20:26:00 -0000 [thread overview]
Message-ID: <4F0C9ECF.9000502@redhat.com> (raw)
In-Reply-To: <m3fwgfmh2u.fsf@fleche.redhat.com>
On 12/20/2011 02:51 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Here's a start. I didn't really try to confirm if I was extracting the
> Pedro> arguments correctly for any other function bug the Ada runtime's
> Pedro> function in question, but at least it works in the case we're
> Pedro> interested in. :-)
>
> I think it looks pretty good.
>
> If you put this in, I will look at making the next-over-throw code use
> it.
That sounds nice. Joel wasn't very keen on it, so I'm not sure about the Ada
parts. I've now put it at:
https://github.com/palves/gdb/tree/build_prototype
> Pedro> + /* The FULL_NAME pointer is at offset 8 of the object pointed by
> Pedro> + E. */
> Pedro> + full_name_val = value_at (void_ptr_type, e + 8);
>
> 8 seems wrong on 32 bit.
It looked okay to me, as the two preceding members are 4 bytes
each, on both 32-bit and 64-bit, but ICBW.
> Now, of course, we need struct layout code... :-)
In any case, that'd be nice. :-)
--
Pedro Alves
next prev parent reply other threads:[~2012-01-10 20:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 17:33 Pedro Alves
2011-12-07 10:07 ` Joel Brobecker
2011-12-07 15:29 ` Pedro Alves
2011-12-07 16:10 ` Pedro Alves
2011-12-07 22:01 ` Tom Tromey
2011-12-07 23:18 ` Joel Brobecker
2011-12-09 3:50 ` Tom Tromey
2011-12-09 17:20 ` Pedro Alves
2011-12-09 18:00 ` Tom Tromey
2011-12-09 18:13 ` Pedro Alves
2011-12-09 18:40 ` Tom Tromey
2011-12-10 22:53 ` Pedro Alves
2011-12-11 20:33 ` Joel Brobecker
2011-12-20 14:53 ` Tom Tromey
2012-01-10 20:26 ` Pedro Alves [this message]
2011-12-11 17:42 ` [commit] Ada exception catchpoint support cleanup Joel Brobecker
2011-12-11 17:44 ` [commit] Warn if missing debug info for Ada exception catchpoints Joel Brobecker
2011-12-11 18:04 ` [commit/Ada] improve message when cannot insert Ada exception catchpoint Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C9ECF.9000502@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).