From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26949 invoked by alias); 11 Jan 2012 21:41:56 -0000 Received: (qmail 26940 invoked by uid 22791); 11 Jan 2012 21:41:55 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 21:41:34 +0000 Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id q0BLaiZr050804; Wed, 11 Jan 2012 22:36:48 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <4F0E0205.1090903@fgznet.ch> Date: Wed, 11 Jan 2012 21:43:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [patch] make static_assert gdb private References: <4F0DF81F.3040905@fgznet.ch> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00380.txt.bz2 On 11.01.12 22:15, Tom Tromey wrote: >>>>>> "Andreas" == Andreas Tobler writes: > > Andreas> Is this ok for trunk? > > Ok. Thanks. Thank you! > BTW your patch got word-wrapped. That's me being a c&p man. I copied the diff from the terminal into thunderbird. The real diff looks a bit ugly since I overrun the 80 chars per line. Here I have a question about formatting, would the below be better? -static_assert (ARRAY_SIZE (async_reason_string_lookup) == EXEC_ASYNC_LAST + 1); +gdb_static_assert (ARRAY_SIZE (async_reason_string_lookup) + == EXEC_ASYNC_LAST + 1); Andreas