From: Pedro Alves <palves@redhat.com>
To: Valery Khromov <valery.khromov@gmail.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
Date: Thu, 09 Feb 2012 16:10:00 -0000 [thread overview]
Message-ID: <4F33EFED.60502@redhat.com> (raw)
In-Reply-To: <1324411833-38717-1-git-send-email-valery.khromov@gmail.com>
On 12/20/2011 08:10 PM, Valery Khromov wrote:
> This patch provides hardware breakpoint/watchpoint support for
> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation.
Thanks. It looks good to me. I've applied the patch now.
> Also removed not necessary DBREG_DRX macro definition.
> 2011-12-20 Valery Khromov <valery.khromov@gmail.com>
>
> * i386bsd-nat.c: [HAVE_PT_GETDBREGS] (DBREG_DRX): Delete.
But without this bit though. Mark only mentioned that the macro always
exists on amd64, not i386:
> That bit can go. FreeBSD/amd64 has always had the DBREG_DRX macro, at
> least ever since support for debug registers was added.
The code does mention that some versions may need it:
/* Not all versions of FreeBSD/i386 that support the debug registers
have this macro. */
#ifndef DBREG_DRX
#define DBREG_DRX(d, x) ((&d->dr0)[x])
#endif
So if this can also be removed, let's do that separately.
--
Pedro Alves
next prev parent reply other threads:[~2012-02-09 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 2:41 [PATCH] " Valery Khromov
2011-12-20 14:52 ` Tom Tromey
2011-12-20 18:30 ` Valery Khromov
2011-12-21 6:45 ` Joel Brobecker
2011-12-20 15:04 ` Mark Kettenis
2011-12-20 16:12 ` Pedro Alves
2011-12-20 17:52 ` Valery Khromov
2011-12-20 17:53 ` [PATCH 1/2] FreeBSD/amd64: Updates for the recent changes that Pedro Alves made Valery Khromov
2011-12-20 17:56 ` [PATCH 2/2] FreeBSD: Removed definition of DBREG_DRX macro because it is already in FreeBSD Valery Khromov
2011-12-20 19:44 ` [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 Mark Kettenis
2011-12-20 20:38 ` [PATCH v2] " Valery Khromov
2012-01-31 17:50 ` Valery Khromov
2012-02-01 20:27 ` Tom Tromey
2012-02-02 9:03 ` Valery Khromov
2012-02-11 18:51 ` Mark Kettenis
2012-02-11 21:03 ` Valery Khromov
2012-02-09 16:10 ` Pedro Alves [this message]
2011-12-20 16:05 ` [PATCH] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33EFED.60502@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=valery.khromov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).