From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 88C723858410 for ; Mon, 22 Jan 2024 10:32:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88C723858410 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88C723858410 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705919563; cv=none; b=EAq9cgItoNVOgBC9AtTTmbtdgZTkglMD6mOillgjzdjVJnHkUTkHnIL6NMzpo1GAtjGSmj1NkNCJxvpOFMVNSp4at/TiG03eYuBqhe9XTcJ8ptvkYrqFY8nNokp0JnTvfBbCR1n6YaRpHgcPbE9LZ+q1GjgRn0qh0uB9VOXj3rQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705919563; c=relaxed/simple; bh=4Vzo1qh4tYu6Jzolyus2ekBsQl27/Ffm66BmxC0drq0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ud3WgXjLZd1P5xCFuorgEjql/qwQl71d7ZDoxachk2+gh5sgI1UkcEzhPFrxiH5Mo3hN+vZXzZA5l4YbzdPdBzmXVHQq4tutgS5opkgUFPzHCP4C6vyraLzJhBgfV1a13b2azXtfJkz2rOEqFNAEJ2Pduygf+v34K+hnpKPm57M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705919552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GnFo8BC9Js4Z6d5EBJY0Rt1zKRytQhj5mbWabRcMlQs=; b=WvB6TZXW3gBp1VYJC8e/CIIQLHIXcixtfgnkFlflme/1FQY+akUCQegnAHbKs48w57pS0b mtw8n/OZHsQZeUT/C0qpT5ljextHx2fKAnyA8kIdm9CbTRYIAj4csNu2y73soU+faNYKPv 6m4YhQ16FcvXX4y1gAc1tDb0w+6c2Hc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-G_UMHZw-M0q8lI9V_kEGrw-1; Mon, 22 Jan 2024 05:32:30 -0500 X-MC-Unique: G_UMHZw-M0q8lI9V_kEGrw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e5769e2deso28378365e9.2 for ; Mon, 22 Jan 2024 02:32:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705919549; x=1706524349; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GnFo8BC9Js4Z6d5EBJY0Rt1zKRytQhj5mbWabRcMlQs=; b=RWOUNzRzD7ZMSPltF+d5RBTo6/g8kPMQ4Wgf80l89PROj1H83FCv/oHvvnKW9rBBJt Y1DQH0BQW5iUZOGnrCO97TkVbZunyoyB3SctVkkJZtw3IXbXrvk1agRv0PUW44Yc9CWL XSAbWKUSnwQBn256xTq+xP6EqmjWpmzSclrbGE4G/lYAwdIYtt+mSrx2ck5a9/Pk+9JX JlfAxUosYGSxUzs6gFJiCG6N5xewe5eu4KvuL7/IJKLHw82dsPUS/u8sG5TaqDtztGNf aSfbqKVAD0HRWZZCkvNps5+zduIxQzft3eP2/x0yRm2WSJ+D1GDHRbrUl0Rznar3yNww nf3Q== X-Gm-Message-State: AOJu0YwrXQ51k5A1ns5p6BBjnONvcqUC1boF/fo9R2tLtmCAgjjuRIAe QpuAEn1h/JyMh8X8yFvauXhU8BPe5pSFsslluiIyX1vILwZAay1Q6Lbrzg1t2gRbKcY4cep6/k+ /pxCbk3CXkPVHU+0VRLvcOMns9IqpKfNZAMKuZcg/BaIdxX3X7Xj8W1kw04M2FRyy3Ns= X-Received: by 2002:a05:600c:b8b:b0:40e:a6bf:af17 with SMTP id fl11-20020a05600c0b8b00b0040ea6bfaf17mr1211354wmb.34.1705919549558; Mon, 22 Jan 2024 02:32:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4XvJ/d+HqkZCkimLauJXnm+s3/6w+M5HSxBO/K5MdWqhuroHEGiJuEAPqAUuaVmlH/4XIdQ== X-Received: by 2002:a05:600c:b8b:b0:40e:a6bf:af17 with SMTP id fl11-20020a05600c0b8b00b0040ea6bfaf17mr1211352wmb.34.1705919549232; Mon, 22 Jan 2024 02:32:29 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id u21-20020a05600c139500b0040e4a7a7ca3sm38689127wmf.43.2024.01.22.02.32.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 02:32:28 -0800 (PST) Message-ID: <4a10e734-3743-4d8d-b61e-c2180b84cb36@redhat.com> Date: Mon, 22 Jan 2024 11:32:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: modernize gdb.dwarf2/dw2-noloc.exp To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240103171605.1048532-1-blarsen@redhat.com> <87jzo5kzyc.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87jzo5kzyc.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/01/2024 18:14, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> The test gdb.dwarf2/dw2-noloc.exp predates the dwarf assembler, and uses > Guinevere> some unreliable assumptions about where global labels get put. > Guinevere> Specifically, when using clang to compile the test, both labels it uses > Guinevere> to gauge the adresses of the main function get reshuffled to be side-by-side, > Guinevere> and the debug information ends up making it look like main's high pc is equal > Guinevere> to low pc, meaning we never enter the main function's scope, and that leads to > Guinevere> 22 failures because the "main_*" variables are technically never in scope. > > Guinevere> This patch modernizes the aforementioned test to use the dwarf > Guinevere> assembler, which removes all failures when using clang. It also renames > Guinevere> the .c file to be more inline with current standard. > > Thank you for doing this. It's great whenever we can get rid of one of > these .S files. > > Approved-By: Tom Tromey > > Tom > Thanks, pushed! -- Cheers, Guinevere Larsen She/Her/Hers