Re: [PATCH] sim: ppc: fix some Wpointer-sign warnings

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On 5/19/21 6:32 PM, Mike Frysinger wrote:
> On 19 May 2021 12:46, Tom de Vries wrote:
>> --- a/sim/ppc/hw_memory.c
>> +++ b/sim/ppc/hw_memory.c
>> @@ -190,7 +190,7 @@ hw_memory_init_address(device *me)
>>    if (device_find_property(me, "available") != NULL) {
>>      hw_memory_chunk **curr_chunk = &hw_memory->heap;
>>      int cell_nr;
>> -    unsigned_cell dummy;
>> +    signed_cell dummy;
>>      int nr_cells = device_find_integer_array_property(me, "available", 0, &dummy);
> 
> this one is fine
> 

Committed separately, as attached.

Thanks,
- Tom

[-- Attachment #2: 0001-sim-ppc-fix-Wpointer-sign-warning.patch --]
[-- Type: text/x-patch, Size: 1217 bytes --]

sim: ppc: fix Wpointer-sign warning

When compiling with --enable-werror and CFLAGS="-O0 -g -Wall", we run into:
...
src/sim/ppc/hw_memory.c: In function 'hw_memory_init_address':
src/sim/ppc/hw_memory.c:194:75: error: pointer targets in passing \
  argument 4 of 'device_find_integer_array_property' differ in signedness \
  [-Werror=pointer-sign]
     int nr_cells
       = device_find_integer_array_property(me, "available", 0, &dummy);
                                                                ^
...

Fix this by changing the type of dummy.

---
 sim/ppc/hw_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/ppc/hw_memory.c b/sim/ppc/hw_memory.c
index 09c331c3295..46b22f7b6e3 100644
--- a/sim/ppc/hw_memory.c
+++ b/sim/ppc/hw_memory.c
@@ -190,7 +190,7 @@ hw_memory_init_address(device *me)
   if (device_find_property(me, "available") != NULL) {
     hw_memory_chunk **curr_chunk = &hw_memory->heap;
     int cell_nr;
-    unsigned_cell dummy;
+    signed_cell dummy;
     int nr_cells = device_find_integer_array_property(me, "available", 0, &dummy);
     if ((nr_cells % 2) != 0)
       device_error(me, "property \"available\" invalid - contains an odd number of cells");