From: tdevries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "set debug timestamp"
Date: Wed, 28 Dec 2022 06:59:00 +0000 [thread overview]
Message-ID: <4a6fb6caabed73555dcca9cdbb75311e@suse.de> (raw)
In-Reply-To: <20221227233653.1151849-1-tom@tromey.com>
On 2022-12-27 23:36, Tom Tromey wrote:
> PR cli/29945 points out that "set debug timestamp 1" stopped working
> -- this is a regression due to commit b8043d27 ("Remove a ui-related
> memory leak").
>
> This patch fixes the bug and adds a regression test.
>
I've applied the patch, ran the regression test without rebuilding and
verified that it failed, then rebuild and verified that it passed.
The code LGTM.
FWIW, I think the regexp could be make more readable using $decimal:
...
-gdb_test "print 23" "\[0-9\]+\\.\[0-9\]+ Operation: OP_LONG.* = 23"
+gdb_test "print 23" "$decimal\\.$decimal Operation: OP_LONG.* = 23"
...
> I think this should probably be backported to the gdb 13 branch.
>
Agreed.
Thanks,
- Tom
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29945
> ---
> gdb/testsuite/gdb.base/timestamp.exp | 24 ++++++++++++++++++++++++
> gdb/top.c | 2 +-
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100644 gdb/testsuite/gdb.base/timestamp.exp
>
> diff --git a/gdb/testsuite/gdb.base/timestamp.exp
> b/gdb/testsuite/gdb.base/timestamp.exp
> new file mode 100644
> index 00000000000..3d124b450e5
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/timestamp.exp
> @@ -0,0 +1,24 @@
> +# Copyright 2022 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see
> <http://www.gnu.org/licenses/>.
> +
> +# Test that timestamps are printed when logging.
> +
> +clean_restart
> +
> +# This is a simple way to get logging output.
> +gdb_test_no_output "set debug expression 1"
> +gdb_test_no_output "set debug timestamp 1"
> +
> +gdb_test "print 23" "\[0-9\]+\\.\[0-9\]+ Operation: OP_LONG.* = 23"
> diff --git a/gdb/top.c b/gdb/top.c
> index 565b455a020..91b4e6a3cfe 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -305,7 +305,7 @@ ui::ui (FILE *instream_, FILE *outstream_, FILE
> *errstream_)
> m_gdb_stdout (new pager_file (new stdio_file (outstream))),
> m_gdb_stdin (new stdio_file (instream)),
> m_gdb_stderr (new stderr_file (errstream)),
> - m_gdb_stdlog (m_gdb_stderr)
> + m_gdb_stdlog (new timestamped_file (m_gdb_stderr))
> {
> unbuffer_stream (instream_);
next prev parent reply other threads:[~2022-12-28 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 23:36 Tom Tromey
2022-12-28 6:59 ` tdevries [this message]
2022-12-28 17:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a6fb6caabed73555dcca9cdbb75311e@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).