From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by sourceware.org (Postfix) with ESMTPS id 6C90D3858434 for ; Thu, 5 May 2022 09:06:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C90D3858434 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GjyAaPdR40bHXesCAjF8xo6sfAhSjqNqpFRRfLwysuVijv2TAC+agzqw0mLMJ9luzbKnfeFG3kW8Q0/z1NbvSw71n3mZh3ilU3LEXraiJwiE1EE9ZEGreStRJSAk7yWBP1ZIMLJLqbfLrjUlYmqEoeecF6PGnC9jOlToC2Qcxv8IFV16zIvVp5BfSBXY7DekcgjwQg65qFTaUhm9IhDgkIuw/vvy15U6UswF+xuzmZydPvZRVNc8q8mdoQ1+foS6ac/u/DtckQe44NxKqmQV5H0ryn7Le43wEYU0m3JSjVtyohkJH7Jy0kyrCLIKyqViRqQ9rdwmtHrHRz+c2I3rdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzpWx8UhUgFJf0YaNZ08pBbeymQ9GCGcBQFWsiNKiA4=; b=fAzjF5X1yJivEvp4C++IQbSI24wy/zUzX/iScTv0nZ+eI7FQiUS6UnDkKiaPTsEA61/LuaLmZUz6zl24O32HxoPGldEpDcF5Tdy44pwPJ1FaH5ZiF3qMHnzcRGaas/2B1NHlnFON92CBuDCBwkXp19q6Q6gBcbD5oNmL6/KYsgON5FUn8EBSfWePB/ID/T+WRlpYC/aC5R+LJ8FYzxWaAoRJNAtuQNBtq0hhVE2wJdP98y9nwGuD4kGUq4fzyLLLgtx7DAm6EoTlDU0nbW+DgFaPpA1pB/yXFHF0WZJSwkIucUhKswYMe9HQK6zVUoKbSIn4AwxOsJi5ZmrCWz+9uA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DU2PR04CA0086.eurprd04.prod.outlook.com (2603:10a6:10:232::31) by VE1PR08MB4703.eurprd08.prod.outlook.com (2603:10a6:802:b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Thu, 5 May 2022 09:06:37 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::8c) by DU2PR04CA0086.outlook.office365.com (2603:10a6:10:232::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Thu, 5 May 2022 09:06:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 09:06:37 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Thu, 05 May 2022 09:06:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: effe006751e2ee8d X-CR-MTA-TID: 64aa7808 Received: from de272342a2d8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0FC07ED6-A5AF-45F5-BEFE-655F37DEED0E.1; Thu, 05 May 2022 09:06:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de272342a2d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 09:06:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ec5Ho+gD7AH+Ovw9Wa9LNQ1XXDc+ZJw5O3sh5FNYx9vLKsBJpWxQvxRv3AuYLjBHDXz5yK4eqhyAXtUBCDp1eQy9rweV+dDJozsYtbWwil0vcn+f9t4vd6nh2F/xnuH7eTM3ZQhttMEYiex3aB3teRCZB4jzykwtBNJe426zn0w4aH1oj050Dq5SyuiWYW9+ozy1YrlknaaKFm6mk0mBhP+yhKEfMEQoxH1KZt8rS8m6yj4+JNHZoxdrCwVc3neO3/1NwLBCKXnKjW6ntRlwSPLmo5besJSsN4ErkFw84tJyhfMohSzfIOqkTXjGQBpKbkvTnFotdH9bIG3mgDa8PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzpWx8UhUgFJf0YaNZ08pBbeymQ9GCGcBQFWsiNKiA4=; b=X9aJzwtVjsWfOlmtoTO8yNtLuhDz/P5ziqmmXu+7fjrXmA1qHYpnRJ4t8laedcISIlaiaEjhx/acZBw6P2k1MD/EZ4p3GUDvtqo+UTz/O1E2mtgdz4EdTo78yYYET6dkMK1nQSGlzGC+PBvcTDsTWcAEPn2ssRQxIuxfXOI9TqUuCzmDHWwVCBRPgB6YHY4oduRc5O7R8bEc/2VukW9nu3RHIAkzT8FEe/ooGQObBHynJVxHHLfpCYJBbrNaVoGYI4eLsL60gt8fIK9vqDKzNlGHQZgbm55v/hVH/A3+L0KsclpfBYB4aVzoT8JhShY/qQZMa45RE4zbaGnz5f33iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VI1PR08MB3021.eurprd08.prod.outlook.com (2603:10a6:803:47::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 09:06:28 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5206.025; Thu, 5 May 2022 09:06:28 +0000 Message-ID: <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com> Date: Thu, 5 May 2022 10:06:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220503111913.563509-1-luis.machado@arm.com> <4099d8e4-54e1-0579-a4f4-15a40d4942a5@arm.com> <715abbd2-18bb-28b5-f30b-6d92ca42e8ca@arm.com> From: Luis Machado In-Reply-To: <715abbd2-18bb-28b5-f30b-6d92ca42e8ca@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::23) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 31e2eb00-e0c1-4841-6733-08da2e768f42 X-MS-TrafficTypeDiagnostic: VI1PR08MB3021:EE_|DBAEUR03FT013:EE_|VE1PR08MB4703:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kCCft1g3OjP0YPbECEuPje4m2xj6s87E8b1ONnH1Zx5B4SFk5BE2kAn47QpEm4cGEV7UdIFwxqeypub9FUZspQHjIoeYC/JhahG47WUc37aJhOIQWkEs6zfqwvZYKH59Ga5QvRMGgf6ojjDCfRgOMLP4G+2Yd4OJ3tNKZyb9yehQkfrHO6+lH34vx4s5gc6BkDpcxBvgOWCbOxTJcGxKzHpp6U5kUJKGnJ5u69OcPX5TH3rdbmyY524pycfctZ21KAnh1+DwSbsC/WKsNRfZ/TUprUtyaEZEF5oTcHJKNeZq1et0X5wgsJacRRmCU5PzxgTKXqGem2Uky1mMiBnQGyUA6rWtEZyrzjgJIpwpvZ2PRF9KgnFyo2b8sey0GR/fKqukIGxGokSECF+qBOWz7sDFZNdiP6gMtePbXnaW5klL57N2oEBRTEVsmQkoXIclH6PP2RFewdugt6EqO1A1YsArj6ZBLD1O++riQKOZ6eaQrtnOXPnQPANtpavPqPu9egTtXx2c1ii1HsQHMf8QSCZK/tSNiwjE+258JT4UghYTso30nMeecge0f7Yf3nTYkBEvssvAlWnivSQiwCJqqlMopaQDTNp3PtNfdeiPNntDsCfscZaEsqutNxCoYB+7TbKII4oS9/Xo+FgZcvKnI7wPjZ6getJkpIFbneq7zyKZoFg/eq4MPgTFt9TsiMQXW8Awizd6ku0MLOMm/h5AvPdLwK5MzkQDDeeYHNL2+L+PDXvtQ2IMWd+Gk1fSn88hD2O7B+zC4qrPnB/xcNj5UAoAt+jIdG585En4Lcg8PC97p6J4XO1LyoDTJq3I16WzeetcD7OtHFKWkgctYfkwkyef7e+pluEFJscWkYe2Jvg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(8936002)(8676002)(38100700002)(66946007)(66556008)(31696002)(86362001)(2906002)(316002)(66476007)(44832011)(26005)(53546011)(6506007)(83380400001)(2616005)(6512007)(31686004)(508600001)(186003)(36756003)(966005)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3021 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b4166e35-59b9-4882-bd2f-08da2e7689bd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O66s1NB1pDzU/RhD5Z9jhvKj/XjS9BO/gIyBacJGVHOlxUJG6xKw8AVX1sS1/6EuEz4IFpaw22u42Dq+j6vsRQ90ML1bWJXpZF+Njt3IeCr5Pf+LXpjt7Bq/K1TLr+yOorli8Od5/ogGHi22/dwB7wDm5dfeM/3bLY5tpqzpnWIndc6jiqCtHUTCQDW/jpXS4aRN+Fs0wDRrtgXL1oml2tSV38Jr5XLd/vKq5zNZX4grUYFigshqBOq3vQVC74IOL/o879pceWy7f+naWavbu6vPWxRTtavHiI+Fsdu+WyUt2LwlbgVU78jqgWcnjAeFXp1K1MTZSjbkiMTgC3RD4H1aqmpXjtL2GK1y7iyhbiVJpSSjt1ihHloqrLFTWBeGC1QecxAaYlX2imVUdMdATIg7e3O+adpLPau840r9IhCDWFI/EdjX5aakYOcTyDF28DeI8JAmTUGZa9FF1JmofRvtf7QzT+yxFlXviNi/gIEFELUqnhQ4K0T6IsaoTV9MLEcMvQoCQqRPHGmv3WDpby1zmieGHJOkawBMGSMO41eauAwIYCILd1U+Gxp+z9l6C+beStOUstiZ8DuAmHtyMsvoS2YCi2HJOtUXpAoYXPa1q6vteOkgleVEQobwvXQmscSuZy8n3D6AI0TTlbrbs2d3CPwSGoiONTuZg72NpcbI+IpYoA4tgAtmGjOMknW3VtMZyVAm/BjP3E7aqIRAxgxKcXC9NE0kZuq1e8Ct/83b+WO5i3FW9jHnxnokdqSjMJctxtYHiJAGx+qr4g9IynTdCQphNuLdzqttyazia01x/NiDFy+zhHr3a61y68WQvlO5BinE327XlbOC3iyEGA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(336012)(186003)(31696002)(8676002)(47076005)(70586007)(70206006)(966005)(26005)(508600001)(6486002)(81166007)(356005)(6512007)(8936002)(6506007)(53546011)(316002)(44832011)(36860700001)(2906002)(36756003)(5660300002)(40460700003)(83380400001)(82310400005)(31686004)(2616005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 09:06:37.0858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31e2eb00-e0c1-4841-6733-08da2e768f42 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4703 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 09:06:43 -0000 On 5/3/22 22:51, Luis Machado via Gdb-patches wrote: > On 5/3/22 12:30, Luis Machado via Gdb-patches wrote: >> On 5/3/22 12:24, Pedro Alves wrote: >>> On 2022-05-03 12:19, Luis Machado via Gdb-patches wrote: >>> >>>> --- >>>>   gdb/Makefile.in | 13 +++++++------ >>>>   1 file changed, 7 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in >>>> index 418094775a5..d80087749de 100644 >>>> --- a/gdb/Makefile.in >>>> +++ b/gdb/Makefile.in >>>> @@ -715,9 +715,12 @@ ALL_64_TARGET_OBS = \ >>>>       arch/aarch64-mte-linux.o \ >>>>       arch/amd64.o \ >>>>       arch/riscv.o \ >>>> +    bpf-tdep.o \ >>>>       ia64-linux-tdep.o \ >>>>       ia64-tdep.o \ >>>>       ia64-vms-tdep.o \ >>>> +    loongarch-linux-tdep.o \ >>>> +    loongarch-tdep.o \ >>>>       mips-fbsd-tdep.o \ >>>>       mips-linux-tdep.o \ >>>>       mips-netbsd-tdep.o \ >>>> @@ -734,7 +737,10 @@ ALL_64_TARGET_OBS = \ >>>>       sparc64-netbsd-tdep.o \ >>>>       sparc64-obsd-tdep.o \ >>>>       sparc64-sol2-tdep.o \ >>>> -    sparc64-tdep.o >>>> +    sparc64-tdep.o \ >>>> +    tilegx-linux-tdep.o \ >>>> +    tilegx-tdep.o >>>> + >>> >>> Spurious empty line. >> >> Fixed now. >> >>> >>> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES.  So why did we >>> need to move that one? >> >> *sigh*... I think that needs to be fixed as well. >> >> opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which >> makes it a 64-bit BFD target. So a 32-bit build makes it not register >> a disassembler function (leading to GDB internal errors). >> >> TILE-Gx is a 64-bit core according to >> https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it >> from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES. > > Patch to binutils sent here: > https://sourceware.org/pipermail/binutils/2022-May/120651.html I've pushed the binutils patch. Are there any objections to the gdb-side patch?