From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by sourceware.org (Postfix) with ESMTPS id 2F5D83858C42 for ; Fri, 26 Apr 2024 15:19:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F5D83858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2F5D83858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.208.171 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714144782; cv=none; b=W/x3lwhpCRvDpvwF/xKXvd4Sfr1O0/GMTn6fA0gC7kllofscES8j/z2T17FNwkksFMezoa9nuoFNAc1afDngbNxCuiyoUlU0I0WMCIgoaJTGiLUSestQFBG7BrtwksFbbFC7O7IWbwnNYt6ZL878jBXQw16lw4dsETOyZ8FZTaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714144782; c=relaxed/simple; bh=2X3890wTKjH3G6kiKlUh7QNFx3ocMnCBijEM10xqYy8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=lE21ArXCJmdClx8HfxfGLBvNM00NdgEWLk+GMZjejwRpCQGcQE0kiPAA2iJJc/81rs20NJYtogVgOgmR6U5PPRZwimI2cDbyz6EJWRMtJE/2vLC6FufZE/ZpZ2gTllhga9DRrpSv/EzydrBO0g3jH47flMWfuM7cQ6kVVQ7Qhcs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d8b194341eso21215751fa.3 for ; Fri, 26 Apr 2024 08:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714144780; x=1714749580; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2Roo1z5bfF2Ef9ebD6LG5eCNUWlhq3XryXrShytyvw=; b=bNFzudFEsJgleJuDYgZ7bBK74v0My5h/qy4ahruZTM1GMJw+Smezu6bRO7RKo40hvz ZUrkwqF8AV/dycxIKpOzbUd7Dg04EWu6tnF8bvUtb4bG5zSIc8ZvAiyFiIZFA0uAniWX v9U/kuYOusivaP0iyqsUCpv8ux3+3+mK3oZgWz0XvYrL1qJP7eKgGvY03xEL4AeO/Vz6 DJ41tVHHkErvjBlqWQMfoc6R20F9DhIJ4sQ3F/oZDoere5etuxjysXcjkE3t0eR6GK1q 9RUY5BuV+fb7vd8G2a1zsrlmMAhzDbFvTLFOmAJPv8HaGCKTEIu6VuVbyKLCr/Rr3BEn CubQ== X-Forwarded-Encrypted: i=1; AJvYcCVed0Cr+SqB8UvDGvGuccSLLi0ERgtTLCfc0DYYyKr7kEdlXy2VbOn5fODR3sglzEKsmmRDkd8TSha32IIXU2RBNCSBQ+u7AXThTQ== X-Gm-Message-State: AOJu0YyNz6/xq4lcClajIx6WxotmwVdWM0zp5QhpTCO9bXMTYKR3CY5/ +8PhjOMZcyGO9Zt/7MUYUcUGcpkDhV0BhwqYhxANd1fE5AZMyfn7 X-Google-Smtp-Source: AGHT+IGJL4/ZCFksmqu0XlR75M0rCSDmauJUnysyByMpDP7OAMEUF26xWr62EH2F5t4a8gPxLA1pmw== X-Received: by 2002:a2e:9410:0:b0:2dd:97e:3481 with SMTP id i16-20020a2e9410000000b002dd097e3481mr1588073ljh.51.1714144779474; Fri, 26 Apr 2024 08:19:39 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:eefb:5e83:838f:bb4c? ([2001:8a0:f93d:b900:eefb:5e83:838f:bb4c]) by smtp.gmail.com with ESMTPSA id c9-20020a05600c0a4900b0041b43d2d745sm6302687wmq.7.2024.04.26.08.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 08:19:39 -0700 (PDT) Message-ID: <4b041f84-e36b-449e-9bfa-3e5235411bb1@palves.net> Date: Fri, 26 Apr 2024 16:19:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Add include guard checker and reformatter To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20240419150427.897379-1-tromey@adacore.com> <177261d7-e29f-477b-9716-f76a919fe1a4@simark.ca> <8498b0b3-5e07-451f-8754-d7825f2d2145@palves.net> <35cc3c26-db4a-4594-9a21-9917bd7e41b3@simark.ca> From: Pedro Alves Content-Language: en-US In-Reply-To: <35cc3c26-db4a-4594-9a21-9917bd7e41b3@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 19:43, Simon Marchi wrote: > On 2024-04-19 12:55, Pedro Alves wrote: >> On 2024-04-19 16:26, Simon Marchi wrote: >>> So, after patch 4/4, your script doesn't need to handle the the >>> `defined(FOO_H)` style (OLDDEF in your script). I think you could >>> remove support for that, it would simplify it a little bit. >> >> Doesn't it need to handle it in case someone creates a new header and writes >> defined(FOO_H) manually? You'd still want the hook to fix that. >> > > IMO, after the initial run, the script doesn't really need to auto fix > things, it can just check and report errors. The Black pre-hook fixes things for you instead of reporting formatting issues. I don't see why should this hook be held to different standards?