From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2040.outbound.protection.outlook.com [40.107.243.40]) by sourceware.org (Postfix) with ESMTPS id AF72B3858C74 for ; Thu, 11 Aug 2022 14:08:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF72B3858C74 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyInBk1gmBq2/jkDJ3iyo0aGC/5/4fB/dYmLcK+2pECYPeTWQ1Pbj5nBhPwfimkJQaToMvs6n3MVXlrgrMv2ntrbWNODr7Nq2t7pI3FzQhoOzf+/o3Zp+TMqyK/ulDtS/vCttgbG3YJFs6t52ZtvJeKip9/TOrqkfiEhoVfmeMzrOWOysDqDJFE5INpF3p3f8YDJ5WKjELPg+AiP8oaYQR6la5ooW6PfqEVW+HxeQsVqTebbEI1iQaO5b5KIzzvT5PTEufy6/4NgN9Eoz6ifBBu/2p+5vPFbvqJLtceKcvYnwPyuBYvo9YNjjBfqslw1xb8yoe7kFUOgsdQaspboeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ihZ+PPm1bZczj0tty0CK8kIwq114wbEWkK85enj50E=; b=mkcnWCmNm4kK9nTxANaDyQLeV9nel9ESly7bjQRRZ7rJm9rgO1F3NzPr2ZOaVXVWi9tzu6upprnNCBQ12wCODiiB7l+xfj8ahUalS4gDF5gQdyha1aSRUHQw/B+pDHEmkEzcfrAKygUepjoCydoSPZTP3fLqzyxYl5/x8APLbUpifx3iMsymIXYEzJ7oZ8ldpR9R67WbCQA89uOwYLOC7yc6Wd9MY6JHzYWgwotwzEujuyZ9BnKLyotpdsiZEtICkXC4215b1Uqc6pHt5VahE8nu0XlQ17A2AFgjmLGzQBe4W+JdRjUBXeG8XByXH8gPQU5aP3kEXbODXyCNDxVYTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by DM5PR12MB1561.namprd12.prod.outlook.com (2603:10b6:4:b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Thu, 11 Aug 2022 14:08:14 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::9155:e480:2c04:aed1]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::9155:e480:2c04:aed1%4]) with mapi id 15.20.5525.011; Thu, 11 Aug 2022 14:08:14 +0000 Message-ID: <4b46dde7-b1d6-da32-fe47-934f0046e72a@amd.com> Date: Thu, 11 Aug 2022 15:07:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/3] gdb/varobj: Only re-evaluate invalid globals during re_set Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220804130231.2126565-1-lancelot.six@amd.com> <20220804130231.2126565-4-lancelot.six@amd.com> From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P194CA0043.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::20) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8027b862-d3a5-4875-04dc-08da7ba2ee4f X-MS-TrafficTypeDiagnostic: DM5PR12MB1561:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s0c4BqLBVDkCQCk66toevwaxhwTu9URxS6MWd89+MulHVBImpVC6YzjvWAjPDdo3mKNkZ+milZZ8WPr7aVj70BSWel38KGfzrVbIiRqk6hCy/0K72Q3DgzX0rqj1J+HwbB7zawCJ99tGrmDK2qHmE68bVMST2mm3ZoKVkzmE9FhypU/IMGqkx5wJjO+lQdWCgHRsjpbS8uiwM9kGyQ8MlV7QlqxlRxvfOv00N34s44ywcb05xXGmMaiCsJ1+d3RvUuabuZZYO/jVhsjz8j4eGd6d8xW64GayWPhJsEKZ0ARjyxCXoEf/R0DjAINWZZGrT8I9mV6YxeyzxLYRNws90ZD/wtJ92vea3+xC5G9RuO4aempozfCUOSqtPMmBOgAd6ISGlF22ZJjfpNKGNAbjGVf9/LAFvIW0LkSeo0R2c3J21Gr7c38aXheJkvDJ/0nZy2Txs9bAyEugRN0SHm6HrwjhNhWbscmURyPJ0PCdGRuc8sjskzPcdmHbZ77f5FdFFkV0wJ3N/B7hbwInFpxriCe14+5S2R+Gq9+7eBCRX8D4OlalsanbdXItm66C16HZjAPqACcSaWbgkxnFAtBTJjRCWVacg08Qf7HGIhxJgvI93wB2VM88/jV33qumRai8niJueO+YXGgqJEU6psPH9JhOQ+wReB9QKe6dGTp/QZROS1if2hlCaf2LKzEwHUPXD4u4cqd2m56Pb4zAcE7CokHUUjJG2XefqlYhprh8KZuJ3HCwfan2IO5LCqDkWhrAth8/tyZnF7aszZG+UKxhuKRiV8+JjVNxfpxC1l4C9Bn2Vi8o9LEF8DiUzpgG6fD+td00WCq2qWfnHiX9sWD6KA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5745.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(2616005)(186003)(41300700001)(31686004)(83380400001)(6512007)(6506007)(53546011)(2906002)(6486002)(36756003)(478600001)(66946007)(66556008)(5660300002)(4326008)(66476007)(8676002)(86362001)(6666004)(31696002)(316002)(38100700002)(4744005)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlhhbkxlTUt6Vnh3WVFTZVBqZkk0dU5PTEsyVFBMWEFMUU1sZVBWYnp0cE00?= =?utf-8?B?QXJCRkJRWGZhUDlLeU5ENE9FV0l6T1VtaXZFd1VIVWZGdGpUNElGK29ENGhW?= =?utf-8?B?Vlp5VGVXMlozWVZ4VHNueFp3NEhPdnRLOHJ4cGM5SzJPSWt4cEY0TURRdEZt?= =?utf-8?B?WlNFRHB4S1lHUzFGcVVjcVFQYzU1UjhHU0ptMEdLdDArU0N3V1R1S1JzaVlR?= =?utf-8?B?a1o1ekNVMDF5MGxzM1l5elZyMlhWV0VrREwzdWdOSmdXZFlhMW1LYzg4emFK?= =?utf-8?B?QkdmMEFCQStqV3VkaHQ3cDVFN2hiV2Fob2tHMUJoajJsZUIxL1M2YkpidlZN?= =?utf-8?B?RXVNdktaanFVWnNIMms0M1g1cVl0T1dWckE1STdBMTNTVWdZZXJncVBiYytS?= =?utf-8?B?YXNyRUxrT3Brclc3OEczZk8yREFpYlIrRC96U1RIOFlsSjcwK3VYcm94L3I5?= =?utf-8?B?QW5kRkZ5aFgyc0RrSXA2SWxVcEp5TFVRMG9vWmVWVWZZenVaYmZVME9qcVFa?= =?utf-8?B?djhwQlFBaXdEWFVrS1NtbStGd1BHY3FMYlpUMzJ0eEpocEppb2s3NVlHZjZs?= =?utf-8?B?M1dvU1ZQVmoyZEFvNm5yZGd1TWNmQWdrYlhJUWMxajZObVJuc0k1MVFUMHBV?= =?utf-8?B?bStUTVZyL0hLalIxRDBobUpsOEZnZjFGT0ZDNEx0em9MRjUyOVltbFRlNUs5?= =?utf-8?B?V0RneHpPL1AzV1NSUGRZVE9udUxtNWFxNm04SDBlc0gzYUd0UG4wVVJWbVRn?= =?utf-8?B?dEZjMVVnaC9ZQUp6YXQyTUZBRjJ2YXZLL2svQ1hTWlhDcmh4UHhvQ0paUXZ3?= =?utf-8?B?S0M0UlJQQ2tGcGM0ZjlhOUhsUFN3OHV2YUFZKzloOTRMeVJOV2tseTlHWEVr?= =?utf-8?B?Ui9JMElVTTkxaHQzUFJ4aDVxMjhlMDlKTEJUbmZScS9nYWgyYTBMRkFoZTli?= =?utf-8?B?RzVxcE1BbUJJbi94cm1CNk4wKzVZTzRUUW83ak9qcmRyYU9DcXVxd2JPZ2dp?= =?utf-8?B?WlIyS21uckZRRTNzbEFBd0QrQU1aQ0k2NnhQMDZQMGpSd3k2Y1V1ZGFtMVF0?= =?utf-8?B?OExKYkVla3BLVk9OQnVSQWJ3YUN1M3NFTERRQWw0T24rTUNJcCtyM1RmYldC?= =?utf-8?B?bHVMWEdUamt3YWF4ZlZqRnQ4ZEM5VGFJVUdMRWhPa2FVNkFNVnhZQ0huUUJa?= =?utf-8?B?RDZvVjVHS3RnWURDaVE2THU5UEFCc1VKOUpPY25wNlBPbU82SjZuRmlXL1FY?= =?utf-8?B?L0FPd3VVYmowOXFpbnI5NW90Q2dxZkZaN1hQOHdQSDZkaCtGS1owcThuRmJw?= =?utf-8?B?Y3VhbHFmRHpTZ2ZtMGE4OVp0NXNVQTBYQkREMEluRXBhVzYya3Jmcld3R3N5?= =?utf-8?B?d3M5RGw0b2dlVnVsdHFCMk1mdHJldDl0bkZBN0M1QlAvRTVOU09TNXB4NGRS?= =?utf-8?B?RmExY09ZdUdjeFNnM3VrQjJ4SDRGOUtSMXpYU1dtWHJRbEVWU3VmS3lpWTNz?= =?utf-8?B?RVM3VWM2K2J2YjNqVno0TXJINkhtYmROemxqODVaWDYvTEhkbTNPRGNHK0V1?= =?utf-8?B?S05BamxhQVlqclRwNEZtSEoraHA0NVl5emNkS2dPYno4YnRlY2R2MjBrSE96?= =?utf-8?B?MDhqRDFKcGY5QkdVTFVhMEgwSkxPMmlqYnpqVFdBRG1QOHNqOWxCOUpHTjUv?= =?utf-8?B?TkxnMDlNdkp1WjIyZGZDWjcyaFNOazF2TUtKWjhSK2tzdWh4YjI4UmNnZlF4?= =?utf-8?B?d0g0c0htNU9CQ0FwWjhBYUg4VE8xd0k3VDMreVFuWHZydC9zYUJLVVIwNXNq?= =?utf-8?B?ZklhUlcvTk0yZ2lJV0kySUhPTTBWRHhlbWtLaHVGa2dQKy91TFM0TjNRU1Fv?= =?utf-8?B?ZEpRaG5YRWx1UXAyUFJoQmhnN0VDWVVkU2ZDSGw1Zk4rVkhSNFJBUndSM0tm?= =?utf-8?B?eDNRYlYwbXpQUUVjYi84THRIa1pIV3V6MXZHT2pYSjlEd0lyS0NBUDFXMVlD?= =?utf-8?B?Z3lrbkk2OUN1UE5Td3kzREdnbmhCcUtHaWxnK1RMaEFVZmd2b3JOL2l1WGtX?= =?utf-8?B?K1BYMGJWYm1xTUdRTFZ2b3VLMnNJc1IzbnlaWkZCeC9hcDZxZ1VkcVU1UEFO?= =?utf-8?B?Z3haMTRDQVBkemZTUHZsTmhhRmZYbjl4TkhLeGFIRGsrakV3Q2p4dzE4WldL?= =?utf-8?Q?SnEzAm1/a2b4EZJlOX6KYLS6jseVtiEc07vJgIMtcdn8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8027b862-d3a5-4875-04dc-08da7ba2ee4f X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 14:08:14.3170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wqrbqTfYaMc8IjnxcnPJmTJJ49om4Cv4sCLIOJwDr9JvYnFtBE516QgsBvKJ3X0eVHMXXRcRBdL27eb3pOPu8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1561 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 14:08:19 -0000 On 09/08/2022 11:55, Tom de Vries wrote: > [CAUTION: External Email] > > On 8/4/22 15:02, Lancelot SIX wrote: >> When doing varobj_re_set, we currently try to recreate floating varobj. >> This was introduced by 4e969b4f0128 "Re-evaluate floating varobj as part >> of varobj_invalidate" to deal with use a after free issue.  However >> since bc20e562ec0 "Fix use after free in varobj" we now ensure that we >> never have dangling pointers so this all recreation is not strictly >> needed anymore for floating varobjs. >> >> This commit proposes to remove this recreation process for floating >> varobjs. >> >> Tested on x86_64-linux. > > LGTM. > > Thanks, > - Tom Hi, Thanks. I have done the changes you asked in patch #1 locally. I am about to push the series. Best, Lanceolt.