From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3384 invoked by alias); 2 Dec 2016 14:24:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3217 invoked by uid 89); 2 Dec 2016 14:24:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1070, mechanism X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Dec 2016 14:24:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79DB7A1003; Fri, 2 Dec 2016 14:23:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2ENw6F021298; Fri, 2 Dec 2016 09:23:58 -0500 Subject: Re: [RFA 5/8] Add value_freer To: Tom Tromey , gdb-patches@sourceware.org References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-6-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <4b4f467f-5881-fff3-75e3-24a36920ad36@redhat.com> Date: Fri, 02 Dec 2016 14:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480395946-10924-6-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00088.txt.bz2 On 11/29/2016 05:05 AM, Tom Tromey wrote: > This adds a value_freer class, that records the value mark in the > constructor and then calls value_free_to_mark in the destructor. It > then updates various spots in gdb to use this class, rather than a > cleanup. > > It would be better overall to replace "struct value *" with a > shared_ptr, maybe eliminating the need for this class (watchpoints > would perhaps need some new mechanism as well). However, that's > difficult to do. > > 2016-11-28 Tom Tromey > > * python/py-value.c (valpy_dereference, valpy_referenced_value) > (valpy_reference_value, valpy_const_value, valpy_get_address) > (valpy_get_dynamic_type, valpy_lazy_string, valpy_do_cast) > (valpy_getitem, valpy_call, valpy_binop_throw, valpy_negative) > (valpy_absolute, valpy_richcompare_throw): Use value_freer. > * dwarf2loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use > value_freer. > * dwarf2-frame.c (execute_stack_op): Use value_freer. > * value.h (value_freer): New class. OK. Thanks, Pedro Alves