From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 73FF93858412 for ; Mon, 22 Nov 2021 18:58:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73FF93858412 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 1E73E390AE2; Mon, 22 Nov 2021 13:58:42 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id NcrIu8qyCgVK; Mon, 22 Nov 2021 13:58:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C2BFC390AE1; Mon, 22 Nov 2021 13:58:41 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com C2BFC390AE1 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0VF-jJ5mKhqG; Mon, 22 Nov 2021 13:58:41 -0500 (EST) Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by mail.efficios.com (Postfix) with ESMTPSA id AD874390ADF; Mon, 22 Nov 2021 13:58:41 -0500 (EST) Subject: Re: [PATCH 3/3] gdb: pass more const target_waitstatus by reference To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <20211122162731.3316783-1-simon.marchi@efficios.com> <20211122162731.3316783-3-simon.marchi@efficios.com> <20211122185636.GJ2514@redhat.com> From: Simon Marchi Message-ID: <4b519589-c396-dc2b-2101-25834530c5fd@efficios.com> Date: Mon, 22 Nov 2021 13:58:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211122185636.GJ2514@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 18:58:43 -0000 On 2021-11-22 1:56 p.m., Andrew Burgess wrote: > * Simon Marchi via Gdb-patches [2021-11-22 11:27:31 -0500]: > >> While working on target_waitstatus changes, I noticed a few places where >> const target_waitstatus objects could be passed by reference instead of >> by pointers. And in some cases, places where a target_waitstatus could >> be passed as const, but was not. Convert them as much as possible. > > LGTM. > > Thanks, > Andrew Thanks, pushed all three patches. Simon