From: Luis Machado <luis.machado@arm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Fix "finish" for vector types on ARM
Date: Mon, 30 Oct 2023 09:36:14 +0000 [thread overview]
Message-ID: <4b588d27-2047-4a8c-be05-eb8a21957122@arm.com> (raw)
In-Reply-To: <877cn8m07m.fsf@tromey.com>
On 10/27/23 18:42, Tom Tromey wrote:
>>>>>> "Luis" == Luis Machado <luis.machado@arm.com> writes:
>
>>> I tested this using the AdaCore internal test suite; the test case
>>> that caught this is identical to gdb.base/gnu_vector.exp.
>
> Luis> Unfortunately I'm not sure passing vector types around is exercised by the testsuite, in
> Luis> particular for ARM.
>
> Luis> Do you have an example test where this is failing? I'd like to make sure things still
> Luis> work for non-BE ARM.
>
> The test code itself in the AdaCore test suite is pretty much identical
> to gdb's gnu_vector.exp. I don't know if that can run on ARM or not --
> but if not, it should be fixed, because it runs fine internally.
>
> Could you try that?
>
I don't see any change to the results of that test with or without your patch. This is likely
broken code for BE only, which is not well-exercised.
Do you have some stats on how well the BE testsuite runs for 32-bit ARM?
> FWIW, AdaCore is also doing little-endian ARM testing.
>
> Tom
Approved-By: Luis Machado <luis.machado@arm.com>
next prev parent reply other threads:[~2023-10-30 9:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 19:15 [PATCH 0/5] ARM function-calling / return fixes Tom Tromey
2023-10-20 19:15 ` [PATCH 1/5] Fix calls with small integers on ARM Tom Tromey
2023-10-23 13:14 ` Luis Machado
2023-10-27 18:08 ` Tom Tromey
2023-10-30 9:38 ` Luis Machado
2023-10-20 19:15 ` [PATCH 2/5] Fix "finish" with range types " Tom Tromey
2023-10-23 13:14 ` Luis Machado
2023-10-20 19:15 ` [PATCH 3/5] Fix "finish" for vector " Tom Tromey
2023-10-23 14:03 ` Luis Machado
2023-10-27 17:42 ` Tom Tromey
2023-10-30 9:36 ` Luis Machado [this message]
2023-10-30 13:44 ` Tom Tromey
2023-10-30 13:53 ` Luis Machado
2023-10-20 19:15 ` [PATCH 4/5] Fix range-type "return" command " Tom Tromey
2023-10-23 13:15 ` Luis Machado
2023-10-20 19:15 ` [PATCH 5/5] Fix fixed-point "return" " Tom Tromey
2023-10-23 13:16 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b588d27-2047-4a8c-be05-eb8a21957122@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).