From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Aditya Kamath1 <Aditya.Kamath1@ibm.com>
Cc: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: Re: [Patch] Fix Assertion pid 0 failure in AIX while running gdb.threads/foll-fork-other-thread
Date: Tue, 2 May 2023 14:52:17 +0000 [thread overview]
Message-ID: <4b5e8b11f44efb01932058d87a4a1e2a43b207f9.camel@de.ibm.com> (raw)
In-Reply-To: <CH2PR15MB3544A2D62E3AA5889788C241D66F9@CH2PR15MB3544.namprd15.prod.outlook.com>
Aditya Kamath1 <Aditya.Kamath1@ibm.com> wrote:
>Please find attached the patch.
Thanks! There still seem to be a couple of issues:
>- inferior *inf = current_inferior ();
>+ inferior *inf_curr = current_inferior ();
> /* When attaching / handling fork child, don't try activating
> thread debugging until we know about all shared libraries. */
>- if (inf->in_initial_library_scan)
>+ if (inf_curr->in_initial_library_scan)
> return;
I think you should just use the incoming "inf" instead of
calling current_inferior again here.
> new_objfile (struct objfile *objfile)
> {
> if (objfile)
>- pd_enable ();
>+ pd_enable (NULL);
> }
This looks wrong - pd_enable (NULL) never does anything.
I think this needs to be pd_enable (current_inferior ()) here.
Otherwise this looks good now.
Bye,
Ulrich
next prev parent reply other threads:[~2023-05-02 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 9:45 Aditya Kamath1
2023-04-27 12:20 ` Ulrich Weigand
2023-05-02 11:49 ` Aditya Kamath1
2023-05-02 12:53 ` Ulrich Weigand
2023-05-02 13:55 ` Aditya Kamath1
2023-05-02 14:06 ` Ulrich Weigand
2023-05-02 14:40 ` Aditya Kamath1
2023-05-02 14:52 ` Ulrich Weigand [this message]
2023-05-02 15:22 ` Aditya Kamath1
2023-05-02 15:33 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5e8b11f44efb01932058d87a4a1e2a43b207f9.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).