From: Phil Muldoon <pmuldoon@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak")
Date: Thu, 01 Feb 2018 10:26:00 -0000 [thread overview]
Message-ID: <4b5f87ca-d783-2eae-a367-33f5a05be8f5@redhat.com> (raw)
In-Reply-To: <20180201094559.zfqwrjixo3iuc7f2@adacore.com>
On 01/02/18 09:45, Joel Brobecker wrote:
> [hi Eli -- not sure if the attached patch is obvious or not, so I will
> wait for your approval, assuming Phil confirms. Thank you!]
>
> Hi Phil,
>
> Can you clarify something for me?
>
>>> diff --git a/gdb/NEWS b/gdb/NEWS
>>> index 2bad096a86..1d26ea4af7 100644
>>> --- a/gdb/NEWS
>>> +++ b/gdb/NEWS
>>> @@ -24,6 +24,10 @@
>>> gdb.new_thread are emitted. See the manual for further
>>> description of these.
>>>
>>> + ** A new command, "rbreak" has been added to the Python API. This
>>> + command allows the setting of a large number of breakpoints via a
>>> + regex pattern in Python. See the manual for further details.
>
> Based on the implementation, I'm pretty sure that it's actualy a new
> function, rather than a new command; is that correct?
>
> If I am, I would like to suggest the following change to the NEWS file,
> to make it clearer.
It's a Python implementation of rbreak. I thought about making prbreak
as a Python implementation of a GDB command but decided to leave it as
an API call instead. However you want to word it is totally
fine. Sorry for any confusion introduced!
Cheers
Phil
next prev parent reply other threads:[~2018-02-01 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:30 [python][patch] Python rbreak Phil Muldoon
2017-10-11 12:11 ` Eli Zaretskii
2017-10-11 12:27 ` Phil Muldoon
2017-10-11 16:19 ` Kevin Buettner
2017-10-11 16:24 ` Phil Muldoon
2017-10-13 8:08 ` Phil Muldoon
2017-10-16 22:22 ` Simon Marchi
2017-10-16 23:01 ` Phil Muldoon
2017-10-17 0:24 ` Simon Marchi
2017-11-03 9:46 ` Phil Muldoon
2017-11-03 10:05 ` Eli Zaretskii
2017-11-13 19:29 ` Phil Muldoon
2018-02-01 9:47 ` [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak") Joel Brobecker
2018-02-01 10:26 ` Phil Muldoon [this message]
2018-02-01 16:21 ` Eli Zaretskii
2018-02-01 17:32 ` Joel Brobecker
2018-02-01 18:25 ` Eli Zaretskii
2018-02-02 3:16 ` Joel Brobecker
2018-02-09 4:30 ` Joel Brobecker
2018-02-09 9:26 ` Eli Zaretskii
2018-02-09 12:13 ` Joel Brobecker
2017-11-14 20:23 ` [python][patch] Python rbreak Simon Marchi
2017-11-16 14:19 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5f87ca-d783-2eae-a367-33f5a05be8f5@redhat.com \
--to=pmuldoon@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).