From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68820 invoked by alias); 1 Feb 2018 10:26:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68810 invoked by uid 89); 1 Feb 2018 10:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=you! X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 10:26:21 +0000 Received: by mail-wm0-f41.google.com with SMTP id f71so4786327wmf.0 for ; Thu, 01 Feb 2018 02:26:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k8c6GE3JXqtRNcPXie3W92YYqA1ffZ4dY+4la0h1Xao=; b=HzWpoJVfB7CJM8EO1ql1vbinoMrbgtcS90EfhHHFLGScPvEWNcFnO3aukhoR1CoARk n9rBwdjXdVbEhaxtEnBcbUMCUWeAhQxG1v3V1CZCnrsfn2L+fu3Wv02NJku5twjSjnv/ WQ68jN0i/+OR56u97Ql2tWEuKyZ/C/a35MB6Ox9HWaxSq4b/uNClQEBkEedcV86tgPNu LD+++bT4gXePVNWnSbveVHnHSf1Pj7z5A9ASpMFpyZUHsIO6zumVSN5uka/UVAgk4TNr 705YYA/Ai2K9H3QMlkMELmm/CX1lxMPTjpYUgDA6do4PbpBRD2BIC1CvyO/x6n+ZSZwm DQ1w== X-Gm-Message-State: AKwxytetPfY2uGHs8oeBE2wH0juisFmKu6ToqJzIKu+damlXVlVCEpbw bNCrocSHEXN5hPyp33x6yAwpWQICt2Y= X-Google-Smtp-Source: AH8x226KJndxIeVbc0p3rHj0e4Oj167dl7wA898Oouc5g7GX2zeljAhPLMcCJBL0czRph5+jGoGqag== X-Received: by 10.28.173.20 with SMTP id w20mr24142865wme.15.1517480778723; Thu, 01 Feb 2018 02:26:18 -0800 (PST) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id p5sm2194385wmf.13.2018.02.01.02.26.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2018 02:26:17 -0800 (PST) Subject: Re: [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak") To: Joel Brobecker , Eli Zaretskii Cc: Simon Marchi , gdb-patches@sourceware.org References: <5e1ba7e3-5f6e-2478-30a5-7670ec7a9879@redhat.com> <3193f5c7a0c98c548722bb6c143f347e@polymtl.ca> <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> <20180201094559.zfqwrjixo3iuc7f2@adacore.com> From: Phil Muldoon Message-ID: <4b5f87ca-d783-2eae-a367-33f5a05be8f5@redhat.com> Date: Thu, 01 Feb 2018 10:26:00 -0000 MIME-Version: 1.0 In-Reply-To: <20180201094559.zfqwrjixo3iuc7f2@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00003.txt.bz2 On 01/02/18 09:45, Joel Brobecker wrote: > [hi Eli -- not sure if the attached patch is obvious or not, so I will > wait for your approval, assuming Phil confirms. Thank you!] > > Hi Phil, > > Can you clarify something for me? > >>> diff --git a/gdb/NEWS b/gdb/NEWS >>> index 2bad096a86..1d26ea4af7 100644 >>> --- a/gdb/NEWS >>> +++ b/gdb/NEWS >>> @@ -24,6 +24,10 @@ >>> gdb.new_thread are emitted. See the manual for further >>> description of these. >>> >>> + ** A new command, "rbreak" has been added to the Python API. This >>> + command allows the setting of a large number of breakpoints via a >>> + regex pattern in Python. See the manual for further details. > > Based on the implementation, I'm pretty sure that it's actualy a new > function, rather than a new command; is that correct? > > If I am, I would like to suggest the following change to the NEWS file, > to make it clearer. It's a Python implementation of rbreak. I thought about making prbreak as a Python implementation of a GDB command but decided to leave it as an API call instead. However you want to word it is totally fine. Sorry for any confusion introduced! Cheers Phil