From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 36C823858429 for ; Thu, 11 Aug 2022 11:56:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36C823858429 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF6D95CC62; Thu, 11 Aug 2022 11:56:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CEE8A1342A; Thu, 11 Aug 2022 11:56:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pB80MXDu9GKTNwAAMHmgww (envelope-from ); Thu, 11 Aug 2022 11:56:32 +0000 Message-ID: <4ba9f6cd-7571-541d-7850-8f8d48d82e7e@suse.de> Date: Thu, 11 Aug 2022 13:56:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] gdb/mi: fix breakpoint script field output Content-Language: en-US To: Simon Marchi , Simon Marchi , Tom Tromey , Simon Marchi via Gdb-patches References: <20220504121342.1208374-1-simon.marchi@polymtl.ca> <875yls6u6v.fsf@tromey.com> <513cd96d-d945-392f-7d72-769c77f9275b@simark.ca> From: Tom de Vries In-Reply-To: <513cd96d-d945-392f-7d72-769c77f9275b@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 11:56:35 -0000 On 8/10/22 21:38, Simon Marchi via Gdb-patches wrote: > > > On 2022-05-26 14:21, Simon Marchi via Gdb-patches wrote: >> >> >> On 2022-05-26 14:10, Tom Tromey wrote: >>>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >>> >>> Simon> The "script" field, output whenever information about a breakpoint with >>> Simon> commands is output, uses wrong MI syntax. >>> >>> I think this is PR mi/24285. >> >> Thanks, will add the footer. >> >>> >>> Simon> Fix it, keeping the backwards compatibility by introducing a new MI >>> Simon> version (MI4), in exactly the same way as was done when fixing >>> Simon> multi-locations breakpoint output in [2]. >>> >>> Simon> - Add a fix_breakpoint_script_output uiout flag. MI uiouts will use >>> Simon> this flag if the version is >= 4. >>> >>> I was under the impression that MI version 3 was somehow experimental, >>> so we didn't need version 4 yet. But maybe the idea is to roll out new >>> MI versions with some regularity and just update the version whenever we >>> think we've made a breaking change? >> >> MI3 is the default today, so not experimental. I think it's fine to >> bump the version and ship it as soon as we make a fix that is also a >> breaking change. There's no reason to hold back fixes. Users (well, >> frontends) are supposed to use the interpreter name with the version in >> it (mi2, mi3) rather than just "mi", so they don't get bad surprises >> when a new MI version is released. And then they can migrate at their >> convenience. >> >> Simon > > I pushed this. > Hi, I'm seeing: ... FAIL: gdb.mi/mi-break.exp: mi-mode=main: test_breakpoint_commands: breakpoint commands: check that commands are set (unexpected output) FAIL: gdb.mi/mi-break.exp: mi-mode=separate: test_breakpoint_commands: breakpoint commands: check that commands are set (unexpected output) ... which looks like due to getting: ... script=["print 10","continue"] ... while expecting: ... script=\{"print 10","continue"\} ... Thanks, - Tom