From: Pedro Alves <palves@redhat.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Eli Zaretskii <eliz@gnu.org>, Yao Qi <qiyaoltc@gmail.com>,
Simon Marchi <simon.marchi@ericsson.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang
Date: Mon, 12 Jun 2017 16:55:00 -0000 [thread overview]
Message-ID: <4bc68337-43ad-cf49-da1f-f7f9b6ffdd09@redhat.com> (raw)
In-Reply-To: <5669db7c-e3c1-3aa6-5f78-dca817b44ba1@redhat.com>
On 06/12/2017 05:45 PM, Pedro Alves wrote:
> On 06/12/2017 05:37 PM, Andrew Pinski wrote:
>> On Mon, Jun 12, 2017 at 9:35 AM, Pedro Alves <palves@redhat.com> wrote:
>>> On 06/12/2017 05:23 PM, Andrew Pinski wrote:
>>>> On Mon, Jun 12, 2017 at 8:54 AM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>>
>>>>> - gdb: Add -Wno-mismatched-tags: We already have a system that tests which
>>>>> warning flags are supported by the current compiler, so this flag will not
>>>>> be included in the builds with GCC. So it's neutral for GCC, and improves
>>>>> the situation for Clang with almost no effort.
>>>>
>>>> This warning is a bug in clang and really should not be warned about
>>>> in either -Wall or -Wextra. I have been complaining about this since
>>>> clang added this option.
>>>
>>> IIRC, the reason this warning exists is because Microsoft's compilers
>>> mangle "struct" and "class" differently, so for projects that
>>> want to be portable to that compiler, it's a helpful warning.
>>> (Whether that should ever be part of -Wall is a separate matter...)
>>>
>>> I don't think we'd want to bend backwards to support MSVC
>>> though. It's so non-conforming that it's scary. Disabling
>>> that warning is the right thing to do, IMO.
>>
>> Why not have clang disable this warning by default instead?
>
> You'll have to ask clang developers.
>
>> I am sorry but people who write C++ should understand that they are the same.
>
> We know the standard says so, and I know that that's true on the ABIs
> we care about. But in practice, what compilers (a project
> cares about) matters more than what the standard says. After all,
> if the standard says the language does X, but no gcc behaves that
> way, we wouldn't ever want code to depend on X, would we?
For reference, so no one thinks I'm making this up: :-)
https://bugzilla.mozilla.org/show_bug.cgi?id=1026535
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-06-12 16:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 19:58 Simon Marchi
2017-06-10 19:58 ` [PATCH 4/5] linux-low: Remove usage of "register" keyword Simon Marchi
2017-06-10 19:58 ` [PATCH 3/5] gdb: Add -Wno-mismatched-tags Simon Marchi
2017-06-10 19:58 ` [PATCH 2/5] gdb: Use -Werror when checking for (un)supported warning flags Simon Marchi
2017-06-10 19:58 ` [PATCH 1/5] gdb: Pass -x c++ to the compiler Simon Marchi
2017-06-10 19:58 ` [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error Simon Marchi
2017-06-14 19:49 ` Sergio Durigan Junior
2017-06-11 2:36 ` [PATCH 0/5] Remove a few hurdles of compiling with clang Eli Zaretskii
2017-06-12 7:56 ` Yao Qi
2017-06-12 14:36 ` Eli Zaretskii
2017-06-12 15:54 ` Simon Marchi
2017-06-12 16:23 ` Andrew Pinski
2017-06-12 16:35 ` Pedro Alves
2017-06-12 16:37 ` Andrew Pinski
2017-06-12 16:45 ` Pedro Alves
2017-06-12 16:55 ` Pedro Alves [this message]
2017-06-12 16:44 ` Simon Marchi
2017-06-12 16:55 ` Andrew Pinski
2017-06-12 17:00 ` Simon Marchi
2017-06-12 16:44 ` Eli Zaretskii
2017-06-13 9:14 ` Yao Qi
2017-06-13 10:23 ` Simon Marchi
2017-06-13 11:06 ` Pedro Alves
2017-06-13 11:08 ` Simon Marchi
2017-06-13 14:38 ` Eli Zaretskii
2017-06-13 17:07 ` Simon Marchi
2017-06-13 19:23 ` Eli Zaretskii
2017-06-13 20:17 ` Simon Marchi
2017-06-14 2:29 ` Eli Zaretskii
2017-06-14 10:45 ` Pedro Alves
2017-06-16 16:12 ` John Baldwin
2017-06-13 15:22 ` Yao Qi
2017-06-13 15:44 ` Eli Zaretskii
2017-06-14 9:07 ` Yao Qi
2017-06-19 8:07 ` Yao Qi
2017-06-13 10:44 ` Pedro Alves
2017-06-13 15:09 ` Joel Brobecker
2017-06-17 21:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bc68337-43ad-cf49-da1f-f7f9b6ffdd09@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pinskia@gmail.com \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).