From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9998E383F85D for ; Sat, 30 May 2020 16:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9998E383F85D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 25CE81E791; Sat, 30 May 2020 12:12:25 -0400 (EDT) Subject: Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <995a0223-b69b-0998-df9e-c83c54673fa1@simark.ca> <20200530160037.fj7mohmused2qhne@function> From: Simon Marchi Message-ID: <4bdbc000-70ea-13bb-60e4-3d4a1f541d67@simark.ca> Date: Sat, 30 May 2020 12:12:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200530160037.fj7mohmused2qhne@function> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 16:12:26 -0000 On 2020-05-30 12:00 p.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 10:39:19 -0400, a ecrit: >> On 2020-05-29 6:00 p.m., Samuel Thibault wrote: >>> Fixes >>> >>> ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool gnu_debug_flag’ >>> 96 | bool gnu_debug_flag = false; >>> ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’: >>> ../../gdb/gnu-nat.c:3511:7: error: cannot >>> >>> gdb/ChangeLog: >>> >>> 2020-05-29 Samuel Thibault >>> >>> * gnu-nat.h (gnu_debug_flag): Set type to bool. >>> >>> diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h >>> index 77c57817b2..7c36778394 100644 >>> --- a/gdb/gnu-nat.h >>> +++ b/gdb/gnu-nat.h >>> @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc); >>> __proc_pid (__proc), __proc->tid, \ >>> host_address_to_string (__proc) , ##args); } while (0) >>> >>> -extern int gnu_debug_flag; >>> +extern bool gnu_debug_flag; >>> >>> #define debug(msg, args...) \ >>> do { if (gnu_debug_flag) \ >>> >> >> Thanks, this is OK. > > Just to be sure, I don't have commit access so can't commit myself. > I didn't see that case documented on > https://sourceware.org/gdb/wiki/ContributionChecklist > linked from > https://www.gnu.org/software/gdb/contribute/ We can either push on your behalf. But if you'd like to have push access, because you plan to make regular contributions, you can ask for an account here, and specify me as "email address of person who approved request". https://sourceware.org/cgi-bin/pdw/ps_form.cgi Simon