public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: osscontribute <osscontribute@gmail.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix faulty use of obstack_free() to *shrink* dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp.
Date: Mon, 23 Oct 2017 20:07:00 -0000	[thread overview]
Message-ID: <4c34afece8de21552d454c01469bdd8e@polymtl.ca> (raw)
In-Reply-To: <77217CC1-7D3D-431C-9B43-8EA3BE956827@gmail.com>

On 2017-10-23 15:55, osscontribute wrote:
> The obstack_free() interface is pretty bad. It actually expects a
> pointer to an existing base (of an object) and not a pointer in the
> middle of a growing object.

Oops, I saw that reply too late.  It would be nice if you could mention 
that in the commit log, for anyone in the future wondering why that 
change was made.

Thanks,

Simon

  reply	other threads:[~2017-10-23 20:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  9:31 Patrick Frants
2017-10-19 10:18 ` Patrick Frants
2017-10-23 16:09 ` Simon Marchi
2017-10-23 17:17   ` Simon Marchi
2017-10-23 19:37     ` Simon Marchi
2017-10-23 19:55       ` osscontribute
2017-10-23 20:07         ` Simon Marchi [this message]
2017-10-23 20:04       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c34afece8de21552d454c01469bdd8e@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=osscontribute@gmail.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).