From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Fix heap-buffer-overflow in cp_find_first_component_aux
Date: Fri, 31 May 2019 12:54:00 -0000 [thread overview]
Message-ID: <4c61d95b-7253-b1c9-abea-dcf5483c0e27@polymtl.ca> (raw)
In-Reply-To: <871s0hxf8t.fsf@tromey.com>
On 2019-05-29 2:55 p.m., Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> [gdb] Fix heap-buffer-overflow in cp_find_first_component_aux
>
> Tom> gdb/ChangeLog:
>
> Tom> 2019-05-25 Tom de Vries <tdevries@suse.de>
>
> Tom> PR gdb/24618
> Tom> * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
> Tom> sure an empty slot (defined by a 32-bit zero pair) is recognized as
> Tom> invalid.
>
> Thanks for the patch and the excellent analysis.
>
> I looked at the history here a little and the earlier code did:
>
> - if (bucket.name == 0 && bucket.vec == 0)
>
> ... so this seems to have just been a simple error in the patch.
>
> This is ok, please check it in.
>
> Tom
Agreed, I was able to reproduce the failure, and the fix LGTM.
Simon
prev parent reply other threads:[~2019-05-31 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 9:35 Tom de Vries
2019-05-29 18:55 ` Tom Tromey
2019-05-31 12:54 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c61d95b-7253-b1c9-abea-dcf5483c0e27@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).