From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 404153898538 for ; Tue, 15 Nov 2022 16:05:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 404153898538 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AFFmSoG018347; Tue, 15 Nov 2022 16:05:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=Ua7xJdccxaHk4VZFDrPksS1lpcGYeGWpf1//BMm/Rb4=; b=eH6mEc7oyN2uYA8k99wdb92BlFxgk5LwK7+BpBFtkeq8cyomQkFB8qH/K5iN9YeFTNLZ hUSzMJo6nnc12L5ZpLEjW1hw4JgGTJaNZE+dYQJvfaeZF/u8vQYcQnUIQz+enhg+DkhR pLSvx3Z5ooXNZxtQWSshlEsIYo50QySci29iKXg8Dqs/wkYfoJDCCCw5BZbDPnsTADVw fpv+jCiP0hxtPV7zX7ekzc+RJrErw6xPCcJNYOY+0nqnLcMRatgwpGQquxGl+d4qwC85 PVVXlY9ezmmod89dRySvyy36/TOSMVZ4mg2gMzkKSactYycJGJYFIKtm5KM3H6r1AfAp /A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kvdr28f00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 16:05:01 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AFFmQOw018243; Tue, 15 Nov 2022 16:05:01 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kvdr28eya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 16:05:01 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AFFpEeW022674; Tue, 15 Nov 2022 16:04:59 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma03dal.us.ibm.com with ESMTP id 3kt349teq5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 16:04:59 +0000 Received: from smtpav06.wdc07v.mail.ibm.com ([9.208.128.115]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AFG4wlv13828772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Nov 2022 16:04:58 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 30BED58062; Tue, 15 Nov 2022 16:04:58 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73AC458064; Tue, 15 Nov 2022 16:04:57 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 15 Nov 2022 16:04:57 +0000 (GMT) Message-ID: <4c6fc2c2180e0d470d8e70801a91a7ee234c5b68.camel@us.ibm.com> Subject: Re: [PATCH 2/2 ver 3] PowerPC, fix support for printing the function return value for non-trivial values. From: Carl Love To: Ulrich Weigand , "gdb-patches@sourceware.org" , "tdevries@suse.de" Cc: "kevinb@redhat.com" , "will_schmidt@vnet.ibm.com" , "blarsen@redhat.com" Date: Tue, 15 Nov 2022 08:04:56 -0800 In-Reply-To: <6ed2cf1714e5b8dc386e66b634b540efdf828ed5.camel@de.ibm.com> References: <2db5ad69b32f4cda9c53b252ad37cd783f827c14.camel@de.ibm.com> <7f476265-c6a9-9fcf-ce13-ff550ea5e6f6@suse.de> <6ed2cf1714e5b8dc386e66b634b540efdf828ed5.camel@de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ibCraftQVXtXidxBFKM7ChwO1us7P5t1 X-Proofpoint-ORIG-GUID: HYle1q1tRDh8rrarTQEH3BWB7ODGgYL8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-15_08,2022-11-15_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1011 mlxscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211150108 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2022-11-15 at 10:16 +0000, Ulrich Weigand wrote: > Tom de Vries wrote: > > On 11/14/22 17:47, Ulrich Weigand via Gdb-patches wrote: > > > I believe all of Kevin's and Bruno's comments have been addressed > > > in this version. I've reviewed it myself as well, and it looks > > > good to me. > > > This is OK. > > On x86_64-linux, I run into a segfault: > > [...] > > (gdb) up > > #1 0x0000000000852d94 in finish_command (arg=0x0, from_tty=0) > > at /home/vries/gdb_versions/devel/src/gdb/infcmd.c:1887 > > 1887 = check_typedef (sm->function->type ()->target_type > > ()); > > (gdb) p sm->function > > $1 = (symbol *) 0x0 > > Ah, I missed that possibility, sorry. > > Carl, if sm->function is NULL, then the whole check needs > to be skipped, and sm->return_buf should be set to 0. > > Can you come up with a fix along those lines (or else, > just revert the patch for now)? Thanks! > Yes, I will take a look and see about fixing or reverting it ASAP. Carl