From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by sourceware.org (Postfix) with ESMTPS id 50DBC3858038 for ; Mon, 4 Jan 2021 21:17:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50DBC3858038 Received: by mail-qv1-xf32.google.com with SMTP id a4so13705774qvd.12 for ; Mon, 04 Jan 2021 13:17:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HFybL2numDy8EA0+ty37s4ZHYIVfq0bEEfj7chTapHA=; b=MrEdbHXBSDJIccGQel8vQ6AK0SGJ1kt2Tosk2psE0LBfcqv5MOAZs9rCaoN9C8s8m3 lpLtZBdzdsFnFOto+svgYWNZlCrGrOIxvD5NBPLQXL1TV8xLj43u91VVDbVebjhjplUM q3WIbm5Vr7kVJcVSVqKKMpXqF/3vZgRYKVjW0Z1Wy3+04Q2mOzFkhWKHzK8VT0oaIrsH 2kG5RQHRk5yJEOd6AMcSXI9xUR7oUNL1L+baXDIRElH7XYOZiUO/W4FScGPH3AO/U1oP tedzictFPbzJq8KMU2CJnqmQGLH+w7hL4tSETFUxm9WSS+PWQI39pW9UypYy4xB/qv4J QATw== X-Gm-Message-State: AOAM532PVhJTwt7kXVQofnfi9+b6FUTTP8q2i2Zei1FVquSQZiLIOp1c eE4tZVkxGXMrjuZp/5otvyfAiQ== X-Google-Smtp-Source: ABdhPJyX//gGdz7HjjwDIuUsWqTqrFBxwHyy+RaRiGo+YF6yKLNB/k4g711MhHnbexrjXymbwudSZg== X-Received: by 2002:a0c:9ccb:: with SMTP id j11mr65012730qvf.44.1609795020859; Mon, 04 Jan 2021 13:17:00 -0800 (PST) Received: from ?IPv6:2804:7f0:8284:7445:c3c:f332:7145:6122? ([2804:7f0:8284:7445:c3c:f332:7145:6122]) by smtp.gmail.com with ESMTPSA id r1sm36568695qta.32.2021.01.04.13.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 13:17:00 -0800 (PST) Subject: Re: [PATCH] Fix building gdb with gcc-4.x To: Bernd Edlinger , "gdb-patches@sourceware.org" , Simon Marchi References: From: Luis Machado Message-ID: <4c952eae-317a-bbf9-d0c9-38c4b2b3fa8c@linaro.org> Date: Mon, 4 Jan 2021 18:16:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 21:17:02 -0000 Hi Bernd, On 1/4/21 5:57 PM, Bernd Edlinger wrote: > Hi, > > with Luis' commit of today the trunk is no longer able to > be compiled with gcc-4.x. > > The problem is std::is_trivially_default_constructible is > not defined before gcc-5 although the compiler supports C++11 > Sorry for the breakage. It looks like GCC 4.x does not fully support C++11, although it used to be able to build GDB. > I am not sure about what's the best approach for conditionally > enabling the code, especially for compilers other than g++. Right now it looks like GDB's requirement is a compiler that (fully?) supports C++ 11. It doesn't seem to name specific minimum versions of compilers. With that said, I wouldn't mind a conditional in the code to support builds with GCC 4.x, if that is deemed important. But as we start using more and more C++ 11 constructs, breakages may happen again in the future. > > > This fixes the build for me. > Is it OK for trunk? > > > Thanks > Bernd. >