From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119855 invoked by alias); 29 Mar 2018 15:04:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118926 invoked by uid 89); 29 Mar 2018 15:04:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:14.3.382.0, m_pc, Hx-spam-relays-external:14.3.382.0, sk:dwarf_r X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Mar 2018 15:04:16 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 5B.A1.23894.D600DBA5; Thu, 29 Mar 2018 17:04:13 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC022.ericsson.se (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 29 Mar 2018 17:04:10 +0200 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Thu, 29 Mar 2018 17:04:10 +0200 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Thu, 29 Mar 2018 17:04:10 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.63] (192.75.88.130) by DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Thu, 29 Mar 2018 15:04:07 +0000 Subject: Re: [RFA 1/2] Make line tables independent of progspace To: "Maciej W. Rozycki" , Simon Marchi CC: Tom Tromey , References: <20180321171809.13115-1-tom@tromey.com> <20180321171809.13115-2-tom@tromey.com> <87zi2uw3uc.fsf@tromey.com> <87vadiw24a.fsf@tromey.com> From: Simon Marchi Message-ID: <4ca333ee-44da-d086-e3c2-cd65b46a46c1@ericsson.com> Date: Thu, 29 Mar 2018 15:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR06CA0086.namprd06.prod.outlook.com (2603:10b6:4:3a::27) To DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88f934ce-72b8-4c77-18df-08d595865244 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM5PR1501MB2005; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;3:9K7hJMEmvOcM2I2DBDQ7qMtiO2izRrBFzzvVZjuSwo2i+Do4JVo51Y3Y2T8wYeY9R4pIGv3DgFfLcTreJpK2MgwBL0fwsklddcEsoKbmm05LkBE5rfNQFVR0GPxsxaQuEwOSsGEaKOYzqepHfwUo/aeJoeI2g8D7IXPKg7F3XL37Ywun1R0ERcXfsohv60v8mCp9HC4gY6uduox/dRfhxwCAflEO9jeP8px2hAytUUYcYeFgq+Dh+CFoj/hxEF7U;25:HjGgzA5Npw+TIzdcrqP6o2IZxCMteXrXimpKN6aeyT8i9XemFt+an1dcdBdqZw9EX9nuq3WHxmUp+g4DTKtVF+wy6OHqoEK1yDajuOICTDv2IHbhDGlrKGqjXdafbetfdlLuGROjfKX5pOni1kfYEmeao6OFwYIW1GECw0B1xJUUpwfyThuIXd3dVg/JLsSOMF6//BJTubbxjK/UJZ/ICr6BJZtcw/jwb2mCL+Z8DXXqjsrE9qvzzGOWZi1Ck0hsXRcbum2YjkKI1PANez9VkUxGkkCJyjWPKrZkecy5F0Izk0xajZJ34xsBAoJUPJzdcDuryPJbTJ407eFshYQP4g==;31:wXZ1maQhLedfBMk/gcxjrslJqe9ayeSR9xN1ZowT/aEtVKaryzBpj5Mjh5r+JA+MD5TMYyUPvwtHuAouwWnSlg5IE2YH9i2sKPCGugN8Z4t60RhxFCNGrGZPdAWxGCwk+j7SQA0yKDvwY5qvlOWqkkPPeC2uyz7X2CMOrEKAviGbPLyi+byufcNTtBedr+B6mpANkAXD5MB6ubkmx2RgS3SOPS8tX64Vc54zRCCj0vU= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2005: X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;20:02oXksMCLAuCZLA/HSFFl47PAIEHjvs4yaTypiwElc/wMcKpu1GFQ0QUFu0uOdHV6XV+3uACxXHGxLgj9VCN1gmNyNVZVvNPpXlJQkx26ZvW7eD7vTPeZEgnP5I3oYvv/Pg+12oYUIvU90vVA983lWueg6PTkgrDA7I1HrTin7mluxspFwBDsQimM6A8l0gBofOJwflw/MQDbvHVWsRz4qWKjbCnPkTRXsZor/M6dJsKs9aru9jUhOz7JjNmdBLBqxwMUO2yF2AWYInMyEuVvyCfPiC3hmlK8Su3N++MdPuF+6kqNmKplhA/rzmNhpBSh+Tecud1TeBBF54lICfbr/u4lieWfNlWO76kwGAryLWjTqZToyAFWQy7Tx38J/o7u8/akqLyyiC2XyEiYiNsn6V5adk2yhRr7cVSSvtuOtgBgv00zmwXm4mt+K/T63CDiKN2k3pr90wPb6VDwxAoj1Fkq/gr6vGTvUmeY3HkSmV9v62sRxxAC3DbzRxrkHJ7;4:Iy8oyVk8/Xt7+j9psVVmE7S2x6aGPkkvHSVhMkYK8nvT688dBaUGSKg4T5cOhIof9khoUNvkMc0qjKqYYyF7nbcOgFuhcp+3XfOZhMjYZ0t/SKaY7OIlBdv4pSy78Abk9ERTp27dB4lCQItIrKDPzjBwRtrAG5THOhQuogfkXzAl5i8Y6A9cgnX+QNfuAv6EOeTXR8eUsL+OjjcmalpL8yggDfJfaLkQ/23vdrBoaVSvuApkHXBKTGTQTJinzu4Ba6mep7f9MgIZ3/c4pYIEjw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:DM5PR1501MB2005;BCL:0;PCL:0;RULEID:;SRVR:DM5PR1501MB2005; X-Forefront-PRVS: 0626C21B10 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39380400002)(376002)(39860400002)(396003)(366004)(346002)(189003)(377424004)(51444003)(199004)(81156014)(31686004)(105586002)(59450400001)(52116002)(23676004)(2486003)(65956001)(81166006)(8936002)(66066001)(26005)(186003)(16526019)(478600001)(47776003)(486005)(6246003)(76176011)(486005)(65806001)(6486002)(49976009)(97736004)(106356001)(53546011)(53936002)(8676002)(386003)(25786009)(230700001)(4326008)(110136005)(36756003)(86362001)(11346002)(316002)(2616005)(446003)(16576012)(956004)(58126008)(3846002)(6666003)(229853002)(65826007)(6116002)(2906002)(93886005)(68736007)(64126003)(476003)(305945005)(7736002)(50466002)(31696002)(5660300001)(52146003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR1501MB2005;H:[142.133.49.63];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDU7MjM6UEwralZOck00K1FhMU83Z3Q3akpDWS9F?= =?utf-8?B?VGt1ekJ2RWRrc1pXRFhZSlo3YWJxRjlqaWltS0NLZ09ka0FrQzAzMDNNVGd6?= =?utf-8?B?TlFMRXlSZCtYMzdyRDJsNHRiWFFvMXhoR3A3U285TDYrKzVEc2ZQOWtWM3FF?= =?utf-8?B?WHB4V2ppWVBCN2xZZnBVM2xkYWN4aGViT3BYS1Y3UE8yZWlSbU4vckNxR2Rn?= =?utf-8?B?LzRIb0F3dTBKcENCNjk2VXp4UzViZVZHNmhqdTg3d2tRYXVoLy8wT1FpVmUx?= =?utf-8?B?Nzdjd1N4K0ZmZlpMR3E2NEVFeHpNZUxMR2tCZ2VuM2svWlcrWlV6emtZQlhq?= =?utf-8?B?dXh3Wkk1Wi83TjBKdmNNMGgzTm5qQys5UXhzdXZBSGJEYWJNcDdicTlSSGdw?= =?utf-8?B?NFJlRlo3Qk10dy8rektaU0I3ekhvN1BxNFhoZjlmQ2lCQWpBalVlQ09keDdS?= =?utf-8?B?VHVLem1tMU9yRGROZURyYS9uQnhxeXhsSTFtamVTSkw5eDJYNG0yUXRYcE8x?= =?utf-8?B?aElKakVLdWMxWS9xZG5COVJ6M3kxOU5oWnRqVFVxSWRLNkhFeVYvSmIyT2s4?= =?utf-8?B?K25VSEZuZjNja29jcGNQYmpmZ2VXaTE1d2ExOWNPbk1VSGxEVTI3Q0E5ZWFO?= =?utf-8?B?bG1IV1cyMHpWcmpyUXFhTGtPUjFSdDV3Z2dLcDhBcjBKTjE0ZldBQ3FrbFZ0?= =?utf-8?B?UnIzZWVTR3RaU0p3M0NmclVqeW9LSFE4UUJjRWREOFFYbXhSMERRcmsxS3FI?= =?utf-8?B?ampFT25aQUxNL2F1bno3VWxiNG1CeGpCcEl0d1JVYnEzd3V2SW9qY1dTN1FT?= =?utf-8?B?aUxib0NnVXpTYkt0ZGpJczFMZzR4U012Q2JzTG1JMVMvUjRTK2FzNDF4Nlds?= =?utf-8?B?SXRSOTNRN2x6RU01TjRlS2YxYVcrSldTVkhhMjR4a1V6dFo1Zi96V25IenpP?= =?utf-8?B?M2dROXltWFVJZFh0dW1DYmY2bFRuQ0RvTmVnN0JDanZucGg1WjFZMnAyczZn?= =?utf-8?B?QkdSTGp1VE03blhFVG1TcS9hOXU0WEVpLzZRNnIvRUw2STJRQW52YWxpRlIy?= =?utf-8?B?T1dRc25kTkxQVW5yaklsZGdpa3JqNG96RzRzUGpMZzlpQ1pTUi9HZEdKUFpN?= =?utf-8?B?U2FHckw4NWVBZ09Kem9kdEw4dm1GWm4xK3kzRjVjWjQwQ083blk3SWNRcXNr?= =?utf-8?B?SXpTOWsvOE5LRGZiemdBRFQ2YnZJRGNzOERSUkxseWV2cnJPSW1uZE5VNm9s?= =?utf-8?B?YWtzZ1hZUUgwWU4rWCtWN3hKUFJzdkhFQ3g4YmpuZXNQVmJVTjNLUTBQZC8z?= =?utf-8?B?VUYreEthdUxUNUJQSEZIVGpNM2hLRGdnWHVBdUYyOFJiZmQrU3NCS2d3UG93?= =?utf-8?B?aDRzZU51Q1g5ZGNLZmM2MTJ4WVNjaXNNbkdudnhwVzIxMkJOR1V3bWoxYy8y?= =?utf-8?B?OG1Ua0JzQlhkNUtpWnZWbk50SkNncHF6N0NPRmFWRlVhc0FuME9JNVdzazBx?= =?utf-8?B?VFg5OTJuQTl3MkpVRCttNk5YMDNBK3NiUll5d2V3OWplN3NPaWxEQ1gwU05G?= =?utf-8?B?Q1VXMnc2T0NyM2JZcUo3VmdYSjgxMmc3OWp3Zmd2NkN1K2FuU0Vud29uSWdw?= =?utf-8?B?czhqZHNiUVpqMDJrSGRLdUNJSGVpMk5vOU8rSm5UakFaOUxvOVpubUZaQ3VV?= =?utf-8?B?SHhRajlGZHN0RlZ5TGFva2U5TUJVQmJWR1IrQnZTVjI2MmRZc0w5OTY2ejJT?= =?utf-8?B?RExrU0lycXlvQVY5Vmd3VFFRaG1SY3FhK0ZubmF2UVR3WGl1b2F4ZGorQklV?= =?utf-8?B?R3hFcjBZZHNzZ0F2cFkvdEs2ejFQZ25uQjNtZGEwQjNkZ2QvR0RzQURnb2xh?= =?utf-8?B?b3RsUlRoNkJ0VWcwME9oZVdaWkNvcEFQTDdNb2R0V3A5cjZ3VjhCQWF6MGY4?= =?utf-8?B?TWErNXBHL1NaVjMwYzhtWHZjWXYxU2hRSEdGdThRcGo3THF1NGtMMUpsWjJ0?= =?utf-8?B?eDQ2SFI4OU9wWndtaURLZHBtRk9CVjNIeHdxcGs4cUhna2o3TTVtQjN1dVkw?= =?utf-8?B?RFdpK0hLV0xvWElhc0NsdTI2K1RUdzRWZXB3ejRQcTFVdFdmRlZJZ3ZmNG9s?= =?utf-8?B?SVovdz09?= X-Microsoft-Antispam-Message-Info: 7M5sRs3cqXg9AEoIgqYVKFDLId8AgWquPiyyuNVLL0FZAuJF/ZUxO47VyKdEiXKa9wLaNOYXflVxOsNwzhKt0QRe8uvPqxSJuQdwrtv3B1OhKNKqy+WMjYr3+VcdGeG9wZT7LXbz4VnV2//0Yemc65xkJ0VKGazLzCpEtF2Cw2xoL8fsaVtZvZ+dGv2TrPZC X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;6:sxHwKRy+R+jayYJivLseiBnSOK6ddO2QZ08k2W5HrOGlxh1O1oK69MNtjCGMVePrGmCX8uxw4bLiUeZ/NrKnOqx3+JJy3YZWmwNY3maNziAMrgOuU5g843UXsAxyFGkwzWoneA04Qu4U3zG6rRdkCihqleA/XRbCPRljP7oFXPzgPD6y1xmR0zB2kbojsMDYdU31muWpUsuCwC5b/JmdhpM246m1Bs4Yy1rKS1GQAAF4zowV7kQFKGJcQc9uRwsLy6NIIxxfcej42dsUzKAaFEEfH5gbzzcojgd3ORfw3SAVEQD79sg1ptAJcPz2Q07gQnPbbaDF/MXz/F1M7dOMai7wAditzaURkJzwvgo0V9xoil1I7UER2zNO6vraHJBupCwsNtV7eMHSQ0vE4xkWaYhBj+ahXV/4Ai0vj5MGPFEL50Q0+Ft4S0vrHvMSTuvUJZcjUiM0knqwNZOAvBOoXA==;5:faemPPJyCTuxRduo8SWSv7QDhmUw83GGXxHoAiSM7OVXaQpRbsUY7XPckAmRIJKjh+G9jJpiQAGiAyI11Kg9kYutSX8EPtOG6njM7m6R7vKesqOrHcDN5Py6mf+RYZ7QtSBNL+Vnq7zWbllon+3bGBpvIPVklsmGBok5K5X6ETM=;24:mG0h76tEZywhzq0vUbisdBKO4DXXU2UDvHYPrgMH9itrTOsNyAoBbHgpOtGLMGKv8YhcBXL04bznWn00+jwEQ0UmDKfE2dY/cvF3YqSu+hs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;7:MQYpjfXBNRdX/EwUGaMmllF//0V8XXtD+rZyudefadBO0JITuu4EtET7TnlgXixs4oi+Na8R2V8gzFbn6VxreprTdsRwkYVdg5NxdfAgLlUIqfJtKmBqtgGG7FfC5lX3m3b5HKkXNN1LHZfukq7zc0cZaGglx3Hq6TS91YnrfJufCDS8m1SksFT75EaEYO6bIhaDYfVal48hEOVBJDa3iy+jAb0+3bvrfRSMEsf+D1qZEp5sgLju9oAmWN5NMYcP X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 15:04:07.8800 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f934ce-72b8-4c77-18df-08d595865244 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2005 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00593.txt.bz2 On 2018-03-28 03:27 PM, Maciej W. Rozycki wrote: > It's not clear to me offhand what the impact on processing that involves > `addr_bits_remove' the change proposed will have. So what specifically > would you like me to comment on here? Err sorry I wasn't very clear. Currently, for addresses coming from the line table, gdbarch_addr_bits_remove is called on the relocated address in dwarf_record_line_1, before that address is put in the line table data structure. In Tom's patch, since we store unrelocated addresses in the line table, relocation happens "just in time" when reading the address from the table. gdbarch_addr_bits_remove is called at this time: CORE_ADDR linetable_entry::address (struct symtab *symtab) const { return gdbarch_addr_bits_remove (get_objfile_arch (SYMTAB_OBJFILE (symtab)), m_pc + ANOFFSET (SYMTAB_OBJFILE (symtab)->section_offsets, SYMTAB_COMPUNIT (symtab)->block_line_section)); } I just wanted to confirm it was still fine with mips' implementation of addr_bits_remove. But now I realize that other arches implement this callback too, not only mips. I think I originally meant to ask about gdbarch_adjust_dwarf2_line, which is only implemented by mips. Since adjust_dwarf2_line used to be passed the relocated address, Tom included a "hack" where he relocates the address, passes it through gdbarch_adjust_dwarf2_line, and unrelocates it: /* Handle DW_LNE_set_address. */ void handle_set_address (CORE_ADDR baseaddr, CORE_ADDR address) { m_op_index = 0; /* Pass the relocated address to the gdbarch for modification, but then only store the relative address. */ address += baseaddr; m_address = (gdbarch_adjust_dwarf2_line (m_gdbarch, address, false) - baseaddr); } I think right now this is necessary, because mips_adjust_dwarf2_line does a minimal symbol lookup, which are relocated. So if we passed an unrelocated address, I guess it wouldn't find the symbol. I just wanted to make sure there wasn't anything you saw that is obviously wrong with this approach. I think that eventually we'll be able to pass an unrelocated address to adjust_dwarf2_line, but in the mean time we probably need this hack. Simon