From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125762 invoked by alias); 11 Jan 2020 03:12:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125752 invoked by uid 89); 11 Jan 2020 03:12:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=bsdkvmc, UD:bsd-kvm.c, bsd-kvm.c, HContent-Transfer-Encoding:8bit X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Jan 2020 03:12:05 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B15EC1E059; Fri, 10 Jan 2020 22:12:03 -0500 (EST) Subject: Re: [PATCH v2 18/24] Multi-target support To: Pedro Alves , gdb-patches@sourceware.org References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-19-palves@redhat.com> From: Simon Marchi Message-ID: <4cc39685-e1d8-72e4-98f2-304bd3fdf7a6@simark.ca> Date: Sat, 11 Jan 2020 03:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191017225026.30496-19-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2020-01/txt/msg00282.txt.bz2 On 2019-10-17 6:50 p.m., Pedro Alves wrote: > @@ -539,14 +574,14 @@ extern void exit_inferior_num_silent (int num); > > extern void inferior_appeared (struct inferior *inf, int pid); > > -/* Get rid of all inferiors. */ > -extern void discard_all_inferiors (void); I'm rebasing my -Wmissing-declarations patch series and see this: CXX inferior.o /home/simark/src/binutils-gdb/gdb/inferior.c:264:1: error: no previous declaration for ‘void discard_all_inferiors()’ [-Werror=missing-declarations] 264 | discard_all_inferiors (void) | ^~~~~~~~~~~~~~~~~~~~~ The declaration of discard_all_inferiors was removed, but not the definition, I guess the intent was to remove the definition as well? Also grepping for it finds one remaining use: bsd-kvm.c:159: discard_all_inferiors (); I presume that this call should just be removed too? Simon