From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107958 invoked by alias); 28 Jun 2017 17:09:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107947 invoked by uid 89); 28 Jun 2017 17:09:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 17:08:58 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB10261B92; Wed, 28 Jun 2017 17:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BB10261B92 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BB10261B92 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A1C258860; Wed, 28 Jun 2017 17:08:55 +0000 (UTC) Subject: Re: [PATCH 14/25] [RFC] GDBserver self test To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-15-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <4cfd0796-bfb0-c073-16c7-954328dcb419@redhat.com> Date: Wed, 28 Jun 2017 17:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-15-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00767.txt.bz2 On 06/12/2017 09:41 AM, Yao Qi wrote: > This patch uses GDB self test in GDBserver. The self tests are run if > GDBserver is started with option --self-test. The name of the corresponding gdb command is "maint selftest", i.e., no hyphen. If wonder if we should be consistent. > > gdb/gdbserver: > > 2017-05-26 Yao Qi > > * configure.ac: AC_DEFINE GDB_SELF_TEST if $development. > * configure, config.in: Re-generated. > * server.c: Include sefltest.h and selftest.c. > (captured_main): Handle option --self-test. > gdb: > > 2017-05-26 Yao Qi > > * selftest.c: Adjust it for GDBserver. > > gdb/testsuite: > > 2017-05-26 Yao Qi > > * gdb.server/unittest.exp: New. I like the idea of running unit tests in gdbserver (and we briefly discussed it when we introduced selftest-arch.c IIRC). But I don't know whether you're proposing the patch as is, or whether it's really just for comments on the idea. I say this because there are several hacks in the patch that ideally we'd avoid. > +#include "../selftest.h" > +#include "../selftest.c" E.g., we should really move these to common/ and void the #ifdefery within them. > +global server_spawn_id > + > +set gdbserver [find_gdbserver] > +set gdbserver_command "$gdbserver --self-test" > + > +set server_spawn_id [remote_spawn target $gdbserver_command] > + > +gdb_expect { > + -i $server_spawn_id > + -re "Ran $decimal unit tests, 0 failed" { > + pass "unit tests" > + } > + -re "Ran $decimal unit tests, $decimal failed" { > + fail "unit tests" > + } Shouldn't this have a "default" case that fails instead of only handling one specific failure mode? Thanks, Pedro Alves