From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id A6C99398400E for ; Fri, 2 Jul 2021 17:55:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6C99398400E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id o13-20020a1c4d0d0000b02901fc90de999bso2932792wmh.1 for ; Fri, 02 Jul 2021 10:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fPkFPiGTKigdPItOJr4Kq/gbaejIlgGRB+s36Y9eqbI=; b=aDTGX3p/wsuy6q4DXq2lIUg7C7+qC3VFsy/Rg779IzqIHmfzsbTUUJeKvrwg0nwMBj BQyKTq/lbH6JTRj4CzEsB7ErjjbwJ8Ch0A2eBN7NiXGpb6dakDEAQ/QUpa5XZ7ldbJmA OUFCkI+m6bmtfKOeU1u/G9lJfyHZyaXsEuY7bs5SleABMQgFf6T6rGCd+DtJ6cDQ9miT b41W6r87t7DKKzT+RwdX7Cn+1MdqtWjYHYPWPnaLR0VJrEDjqBm/vUlmT+GnEdR4bwof bFatckCalRUYfARKII3B0SJml8f6a95RZQjxaZbaTSfUtUblK2ENcvhSsAf1+ncw7zlm HWmw== X-Gm-Message-State: AOAM531QeJANB2snMdk0ZqBEJmFTNxQrWeQasz4dj4YVuIxgfla+6yS9 NaB6XqCT2PvuppUIrkOVx/pkYH7DRGAUOg== X-Google-Smtp-Source: ABdhPJzURwEGbDnoguANkegIvUN+PkBlKR6/uUhhDfSbVXNTTd0rFamTDTVfLeSytp/47Jt5MRH7wg== X-Received: by 2002:a1c:7201:: with SMTP id n1mr1099542wmc.4.1625248509627; Fri, 02 Jul 2021 10:55:09 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id k6sm3570863wms.8.2021.07.02.10.55.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 10:55:08 -0700 (PDT) Subject: Re: [PATCH v3 2/3] gdb: pass child_ptid and fork kind to target_ops::follow_fork From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210610143305.2018627-1-simon.marchi@polymtl.ca> <20210610143305.2018627-3-simon.marchi@polymtl.ca> Message-ID: <4d050d60-f5bf-15e0-9627-8c5c3d05ba78@palves.net> Date: Fri, 2 Jul 2021 18:55:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210610143305.2018627-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 17:55:13 -0000 On 2021-06-10 3:33 p.m., Simon Marchi via Gdb-patches wrote: > -void target_follow_fork (bool follow_child, bool detach_fork); > + This function is called when the inferior or vforks, to perform any when the inferior FORKS or vforks, I guess? > + bookkeeping and fiddling necessary to continue debugging either the parent, > + the child or both. */ > + > +void target_follow_fork (ptid_t child_ptid, target_waitkind fork_kind, > + bool follow_child, bool detach_fork); > Otherwise LGTM. Pedro Alves