From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4A17E386F827 for ; Tue, 12 May 2020 18:34:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A17E386F827 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A95081E79B; Tue, 12 May 2020 14:34:45 -0400 (EDT) Subject: Re: [PATCH v3 4/6] nto_process_target::create_inferior: Pass args as char ** To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200512154211.1311364-1-m.weghorn@posteo.de> <20200512154211.1311364-4-m.weghorn@posteo.de> From: Simon Marchi Message-ID: <4d47445d-5d1b-db85-afbc-34032f0d2eb7@simark.ca> Date: Tue, 12 May 2020 14:34:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200512154211.1311364-4-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 18:34:47 -0000 On 2020-05-12 11:42 a.m., Michael Weghorn via Gdb-patches wrote: > Both, [1] and [2] suggest that the fifth parameter > to the 'spawnp' function is of type 'char * const argv[]', > so just pass the args contained in the vector as > an array right away, rather than converting that > to a C string first and passing that one. > > With commit 2090129c36c7e582943b7d300968d19b46160d84 > ("Share fork_inferior et al with gdbserver", > 2016-12-22) the type had changed from 'char **' > to 'char *', but I can't see an apparent reason for > that, and 'nto_procfs_target::create_inferior' > (in gdb/nto-procfs.c) also passes a 'char **' to > 'spawnp' instead. > > I do not know much about that target and cannot actually > test this, however. > The main motivation to look at this was identifying > and replacing the remaining uses of the 'stringify_argv' > function which does not properly do escaping. > > [1] https://support.sas.com/documentation/onlinedoc/sasc/doc750/html/lr2/zid-9360.htm > [2] https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_74/apis/spawnp.htm I would suggest using this reference instead, which is from QNX Neutrino (the platform this port is for). http://www.qnx.com/developers/docs/7.0.0/#com.qnx.doc.neutrino.lib_ref/topic/s/spawnp.html Otherwise, this patch is OK. Simon