From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E98C6384406C for ; Tue, 6 Apr 2021 16:25:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E98C6384406C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 136GPBAC020252 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Apr 2021 12:25:15 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 136GPBAC020252 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CD9111E590; Tue, 6 Apr 2021 12:25:10 -0400 (EDT) Subject: Re: [PATCH v3 0/7] extend branch tracing to use ARM CoreSight traces To: Zied Guermazi , gdb-patches@sourceware.org References: <20210331025234.518688-1-zied.guermazi@trande.de> <2b5cc0d3-cb97-6252-65dc-7b7db1d1e3f8@polymtl.ca> <075fb603-8493-ebb6-c4e6-995fd71bf41e@trande.de> <9abf7597-acf3-bcea-8d29-a961fe75d238@polymtl.ca> From: Simon Marchi Message-ID: <4d52c574-fc58-6f4c-2cf9-53420c72e685@polymtl.ca> Date: Tue, 6 Apr 2021 12:25:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 6 Apr 2021 16:25:11 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 16:25:18 -0000 On 2021-04-05 3:38 a.m., Zied Guermazi wrote: > hi Simon, > > the first error message looks related to the change log. Yeah, this: /home/simark/src/binutils-gdb/.git/worktrees/avr/rebase-apply/patch:394: trailing whitespace. * btrace-common.h (btrace_format): add BTRACE_FORMAT_ETM This is just a warning (which should be addressed, removing the offending trailing whitespace). But this isn't the main issue, this is: error: patch failed: gdb/record-btrace.c:2950 error: gdb/record-btrace.c: patch does not apply error: patch failed: gdbsupport/btrace-common.cc:36 error: gdbsupport/btrace-common.cc: patch does not apply error: Did you hand edit your patch? The hunks for the source files don't apply. Did you send your patch using git-send-email? > I am adding the change logs manually to the mail, is this fine? how shall the change logs be provided? shall I change the ChangeLog files located under gdb, gdbserver and gdbsupport folder? is it enough to put the change logs in the mail header? Most people put the ChangeLog entries only in the commit message when sending the patch for review, and only move them to the actual ChangeLog files when pushing. This is a habit to avoid unnecessary conflicts in ChangeLog files, where the top lines change all the time (this can also be mitigated using git-merge-changelog). But since you gave me the exact commit, on which to apply the series, it should work regardless. So the patch's formatting has likely been altered in the process of sending it. Simon