Re: [PATCH] Fix build with GCC 7.5

[Tom de Vries <tdevries@suse.de>]

On 11/22/23 15:03, Tom Tromey wrote:
> A recent change to 'struct field' caused a build failure with GCC
> 7.5.0, as reported by Tom de Vries:
> 
> /data/vries/gdb/src/gdb/gdbtypes.h:721:51: error:
> ‘field::m_accessibility’ is too small to hold all values of ‘enum
> class accessibility’ [-Werror]
>     ENUM_BITFIELD (accessibility) m_accessibility : 2;
>                                                     ^
> 
> Mark Wielaard pointed out that this was a GCC bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51242
> 
> This patch works around the bug by changing this member not to be a
> bitfield.  It reduces the size of the enum a bit instead.  I also
> changed m_bitsize to no longer be a bitfield -- that was done for
> packing reasons in ancient times, but with m_accessibility not being a
> bitfield, this no longer matters.
> 
> This patch does not change the size of struct field on 64-bit hosts.

Hi,

thanks for looking into this.

This fixes one of the three warnings.

But I still get:
...
/data/vries/gdb/src/gdb/gdbtypes.h:1616:49: error: 
‘fn_field::accessibility’ is too small to hold all values of ‘enum class 
accessibility’ [-Werror]
    ENUM_BITFIELD (accessibility) accessibility : 2;
                                                  ^
/data/vries/gdb/src/gdb/gdbtypes.h:1662:49: error: 
‘decl_field::accessibility’ is too small to hold all values of ‘enum 
class accessibility’ [-Werror]
    ENUM_BITFIELD (accessibility) accessibility : 2;
                                                  ^
...

Thanks,
- Tom