From: Simon Marchi <simon.marchi@ericsson.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
John Darrington <john@darrington.wattle.id.au>
Cc: Simon Marchi <simark@simark.ca>,
Sergio Durigan Junior <sergiodj@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested.
Date: Mon, 29 Oct 2018 15:52:00 -0000 [thread overview]
Message-ID: <4da7206f-6e6a-7aad-634e-a4485d99e988@ericsson.com> (raw)
In-Reply-To: <yddlg6h15it.fsf@CeBiTec.Uni-Bielefeld.DE>
On 2018-10-29 5:11 a.m., Rainer Orth wrote:
> Hi John,
>
>> However I've checked in a fix for this issue, and tested it by building
>> natively with a hacked set of standard include headers.
>
> you always need to post patches here, if only for reference.
Not only should you post here the patches you push as obvious, but I don't
think that this:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=98a17ece013cb94cd602496b9efb92b8816b3953
falls under the obvious rule:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/MAINTAINERS;h=d5154d394206861ef5471b4984a4762589c34fc4;hb=HEAD#l82
I can't judge whether the patch is right or not with a quick glance, but it
certainly is complex enough to warrant a discussion (as Rainer's reply below
shows).
Additionally, it seems like the initial 4-patch series was pushed without
explicit approval from a maintainer (at least I can't find any). Next time,
please wait to have an approval before pushing. If you are not sure whether
a reply constitutes an a approval, it's better to ask the maintainer to
clarify.
> Besides, we're currently very inconsistent here (haven't checked which
> part of that is due to your code): most places use AF_UNIX, only two use
> AF_LOCAL instead (common/netstuff.c, gdbserver/remote-utils.c), and your
> configure check only checks for AF_LOCAL. I believe we should
> canonicalize for one of the two and allow for systems that define only
> one or the other.
mingw defines AF_UNIX, so I would tend to go towards that route. Any of you
knows what happens at runtime when you try to bind a AF_UNIX socket on mingw/Windows?
Simon
next prev parent reply other threads:[~2018-10-29 15:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:33 Gdbserver can listen on local domain sockets John Darrington
2018-10-09 17:33 ` [PATCH] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested John Darrington
2018-10-09 17:56 ` Eli Zaretskii
2018-10-09 18:02 ` Pedro Alves
2018-10-09 18:41 ` John Darrington
2018-10-09 18:53 ` Pedro Alves
2018-10-09 19:00 ` John Darrington
2018-10-09 19:06 ` Pedro Alves
2018-10-13 17:58 ` [PATCH 1/4] " John Darrington
2018-10-13 17:58 ` [PATCH 2/4] GDB: Document the unix::/path/to/socket of remote connection John Darrington
2018-10-13 18:11 ` Eli Zaretskii
2018-10-15 9:31 ` Simon Tatham
2018-10-15 11:28 ` John Darrington
2018-10-18 20:21 ` Sergio Durigan Junior
2018-10-13 17:58 ` [PATCH 4/4] GDB: Remote target can now accept the form unix::/path/to/socket John Darrington
2018-10-13 17:58 ` [PATCH 3/4] GDB: Fix documentation for invoking GDBSERVER John Darrington
2018-10-13 18:10 ` Eli Zaretskii
2018-10-18 20:27 ` Sergio Durigan Junior
2018-10-19 7:05 ` John Darrington
2018-10-19 20:45 ` Sergio Durigan Junior
2018-10-21 7:33 ` John Darrington
2018-10-21 16:47 ` Sergio Durigan Junior
2018-10-23 18:25 ` John Darrington
2018-10-23 18:58 ` Sergio Durigan Junior
2018-10-13 18:12 ` [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested Eli Zaretskii
2018-10-18 20:18 ` Sergio Durigan Junior
2018-10-19 18:55 ` John Darrington
2018-10-19 19:43 ` Sergio Durigan Junior
2018-10-28 16:20 ` Simon Marchi
2018-10-28 18:10 ` John Darrington
2018-10-28 18:51 ` Simon Marchi
2018-10-29 8:24 ` John Darrington
2018-10-29 9:13 ` Rainer Orth
2018-10-29 9:38 ` Rainer Orth
2018-10-29 15:52 ` Simon Marchi [this message]
2018-10-29 16:26 ` John Darrington
2018-10-29 16:42 ` Sergio Durigan Junior
2018-10-29 17:34 ` John Darrington
2018-10-31 13:54 ` Simon Marchi
2018-10-29 18:32 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da7206f-6e6a-7aad-634e-a4485d99e988@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=john@darrington.wattle.id.au \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=sergiodj@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).