From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DE54A3856DE9 for ; Sat, 23 Apr 2022 02:59:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE54A3856DE9 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8D7E71E00D; Fri, 22 Apr 2022 22:59:52 -0400 (EDT) Message-ID: <4e31bdd8-f675-7959-e4dc-b00c66e45a72@simark.ca> Date: Fri, 22 Apr 2022 22:59:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 00/36] C++-ify breakpoints Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220118194007.2853108-1-tom@tromey.com> <8735i4rhra.fsf@tromey.com> From: Simon Marchi In-Reply-To: <8735i4rhra.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2022 02:59:53 -0000 On 2022-04-22 16:21, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> This series somewhat C++-ifies breakpoints. It turns most > Tom> breakpoint_ops function pointers into virtual methods, and introduces > Tom> a class hierarchy for breakpoints. > > I'd appreciate comments on this series. > > Tom Apart from the small comment on patch 1, I don't have any comments. I appreciate how you managed to split this up in so many steps. If we ever have to bisect a regression due to this series, it will make it much easier. I have attempted this conversion in the patch and didn't finish it, I know how much work that is, good job! Simon