From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A72523834C0E for ; Wed, 7 Dec 2022 14:09:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A72523834C0E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670422170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3rvrXwOOfxawLlM2s/AARCiWAwHFF+3Qj8c+U14cr4=; b=P8+7ugLOtcXbrKVDYQc3fe2f/i5BjRB/W22hA653Aga2hjyPEidLEnC3BSgBALSAvxTRbu MVEvgmOVXX8XQ3xZrkoEvzv4w6ELYMNO1+XxqqXYlvArqe92x/AmOIco27Zg0COT4n38i3 UD4stmmdBqXBFIxGqz9e385C59Ukkg8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-452-JgB2RK5IN-ONAFRIu3oZSg-1; Wed, 07 Dec 2022 09:09:23 -0500 X-MC-Unique: JgB2RK5IN-ONAFRIu3oZSg-1 Received: by mail-wm1-f70.google.com with SMTP id m17-20020a05600c3b1100b003cf9cc47da5so10023521wms.9 for ; Wed, 07 Dec 2022 06:09:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L3rvrXwOOfxawLlM2s/AARCiWAwHFF+3Qj8c+U14cr4=; b=O4NVlXEhyPn/XLzlBwn8TuttzZcWTRELikAfr7B0/qHzVQTcPpDD19+DyPtVwUZd+Y MKjPgecP3oo11xwmEX+sV4L96UDrYYTaipZDZk3MEYG+jUyyWD6wAyS7S55awS1cQxLN gWR9Kyb6FVsHJbIBpBKb69uyJCoYmmuwSt5pzsZHay7u7FMi2aDAovraIiZiUwudfy8f HLSakKiiRg1UW//qZH/WweiGoOKixJrplm2upkkRy4QfXdyBNGWTifiqbGJCeHPGxvMW bA/HXsqDGzS9XvGTje3axjuqpstf7bvO8PJuicZftKG+Jy80cG3wV+TJHVhP7GWfoIN3 L2+g== X-Gm-Message-State: ANoB5pnGavQ0LIDUrk6zss3JM0IVt6VRTPPo5N8W+36fv+gNB3HcKZS/ 1Zo2+9k+2hKtN9bIy/dBoP6bz9T5VjJbtCwE7aKO3YcqRX+mjz1EAxeah/dt/UG9UcEfGPJTRCW DC26GYH8bqwphCKXxPlE5/w== X-Received: by 2002:a05:600c:3d8f:b0:3cf:6a4c:af8b with SMTP id bi15-20020a05600c3d8f00b003cf6a4caf8bmr54768122wmb.115.1670422161974; Wed, 07 Dec 2022 06:09:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf7+S2I4Vs6CM7PYC1sZShc5uza9w6iLHAfdFNlBM6Zq/s+59Our/z/I64fHLpZR5ZAc+ibxZQ== X-Received: by 2002:a05:600c:3d8f:b0:3cf:6a4c:af8b with SMTP id bi15-20020a05600c3d8f00b003cf6a4caf8bmr54768109wmb.115.1670422161725; Wed, 07 Dec 2022 06:09:21 -0800 (PST) Received: from [10.202.9.92] (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id ay19-20020a05600c1e1300b003a1980d55c4sm1798056wmb.47.2022.12.07.06.09.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 06:09:21 -0800 (PST) Message-ID: <4e408f03-21d4-fb9e-ac63-850428a03718@redhat.com> Date: Wed, 7 Dec 2022 15:09:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/6] gdb: add invalidate_selected_frame function To: Simon Marchi , gdb-patches@sourceware.org References: <20221202180052.212745-1-simon.marchi@polymtl.ca> <20221202180052.212745-2-simon.marchi@polymtl.ca> From: Bruno Larsen In-Reply-To: <20221202180052.212745-2-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/12/2022 19:00, Simon Marchi via Gdb-patches wrote: > Instead of using `select_frame (nullptr)` to invalidate the selected > frame, introduce a function to do that. There is no change in behavior, > but it makes the intent a bit clearer. It also allows adding an assert > in select_frame that fi is not nullptr, so it avoids passing nullptr by > mistake. LGTM, and doesn't introduce any regressions Reviewed-By: Bruno Larsen -- Cheers, Bruno > > Change-Id: I61643f46bc8eca428334513ebdaadab63997bdd0 > --- > gdb/frame.c | 16 ++++++++++++++-- > gdb/frame.h | 3 +-- > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/gdb/frame.c b/gdb/frame.c > index b4079ef833e8..6a6d968b9a97 100644 > --- a/gdb/frame.c > +++ b/gdb/frame.c > @@ -1836,11 +1836,23 @@ deprecated_safe_get_selected_frame (void) > return get_selected_frame (NULL); > } > > -/* Select frame FI (or NULL - to invalidate the selected frame). */ > +/* Invalidate the selected frame. */ > + > +static void > +invalidate_selected_frame () > +{ > + selected_frame = nullptr; > + selected_frame_level = -1; > + selected_frame_id = null_frame_id; > +} > + > +/* See frame.h. */ > > void > select_frame (frame_info_ptr fi) > { > + gdb_assert (fi != nullptr); > + > selected_frame = fi; > selected_frame_level = frame_relative_level (fi); > if (selected_frame_level == 0) > @@ -2012,7 +2024,7 @@ reinit_frame_cache (void) > annotate_frames_invalid (); > > sentinel_frame = NULL; /* Invalidate cache */ > - select_frame (NULL); > + invalidate_selected_frame (); > frame_stash_invalidate (); > > for (frame_info_ptr &iter : frame_info_ptr::frame_list) > diff --git a/gdb/frame.h b/gdb/frame.h > index 100ab1fe48eb..cf8bbc6a52bd 100644 > --- a/gdb/frame.h > +++ b/gdb/frame.h > @@ -239,8 +239,7 @@ extern void reinit_frame_cache (void); > and then return that thread's previously selected frame. */ > extern frame_info_ptr get_selected_frame (const char *message = nullptr); > > -/* Select a specific frame. NULL implies re-select the inner most > - frame. */ > +/* Select a specific frame. */ > extern void select_frame (frame_info_ptr); > > /* Save the frame ID and frame level of the selected frame in FRAME_ID