From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30220 invoked by alias); 15 Feb 2019 10:02:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30200 invoked by uid 89); 15 Feb 2019 10:02:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:646, wish X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 10:02:21 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20E6814A98; Fri, 15 Feb 2019 10:02:20 +0000 (UTC) Received: from [10.36.117.17] (ovpn-117-17.ams2.redhat.com [10.36.117.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D0C41024921; Fri, 15 Feb 2019 10:02:19 +0000 (UTC) Subject: Re: [PATCH] Use new Darwin operating system names To: Kevin Buettner , binutils@sourceware.org, Saagar Jha Cc: gdb-patches@sourceware.org References: <20190214191325.2354ddbc@f29-4.lan> From: Nick Clifton Openpgp: preference=signencrypt Message-ID: <4e4b1e4e-57b9-c754-9e49-55c9ad8e1812@redhat.com> Date: Fri, 15 Feb 2019 10:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190214191325.2354ddbc@f29-4.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00251.txt.bz2 Hi Saagar, > > 1) This entry should go in include/ChangeLog, so you don't need to > have the include/ prefix. > > 2) Please adjust it to indicate that only the comments are affected. > Like this, perhaps: > > * mach-o/loader.h: Use new OS names in comments. > > Otherwise, it looks good to me. > > I wish I could tell you to check this in, but I think that the > binutils maintainers will need to approve this change. I've added > binutils@sourceware.org to the "To:" header in my reply. It is fine with the binutils too. So please apply with the changes that Kevin has outlined. Cheers Nick