From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 43E253858D1E for ; Tue, 2 May 2023 10:54:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43E253858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683024884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CuN/1TTk6TQC5yn0vArpQ8BQIbMHoB1NoebzqyLxe0c=; b=KHOIMvdMybORWRYZdlqtxdQRlqnEbOrwJ0WOdhERKf/DfIxMGSq/KAsqOJ9NJofgBEORKA igK1sZFS5SpfxxelHKBuqFwkWVFak5BROC8HVRoeM76lHb7T4oEp+j3jmOSHLMifVutXRr SpXzMW2Ouf6QGMWPoevpJ8lXxm46iAM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-bnlNIiZnOAWsYVMZlSC25A-1; Tue, 02 May 2023 06:54:43 -0400 X-MC-Unique: bnlNIiZnOAWsYVMZlSC25A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-2ff4bc7a6a3so2198372f8f.3 for ; Tue, 02 May 2023 03:54:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683024882; x=1685616882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CuN/1TTk6TQC5yn0vArpQ8BQIbMHoB1NoebzqyLxe0c=; b=SCUkc1nGB813193HdOZvgBfgt7Jvbjp5blyro7DPTstLTZRLaeeVjtVdowRB4JftFn VN3HEF173ckT2fmx4raXnL/RNaEdCweclzVqBJfRq/1NxvJbqXLoNK4fhPd5d1YoAk1u NAHyjS6OmpH/R0Mt+JzTnDVwuHz9/v1pRcLnQV+NA804+Jo6IRatlUkAHHYSeOjX1MUR M6+2UsyuIbFC6RV8d6QmLEUJ9KHjjUUyZ/PIxCmohp3cu5znEz9bBWNiA4NKaguj7SYj iAEqDWGsJTm+rgD4RACV5V7JfajcS7VFb1lOkH9Uj6aQTJYkWDupodc1zhMb7e0+Z8+Z Qoew== X-Gm-Message-State: AC+VfDwdzBVDWP7kXg6Dbst/gzOBL8KEvKusEgMiKXWsXRDqWNsHWk6y s55yloM5LW0FtqwF1dQ75TVbue2jrg4gi2iWc1XFNdHvDrF8etz7g/OliJVGV3VsZPg3rSsNWOB QAeSVrwMU1dIQJ7qy7GRYVMOlkf9d+frRTx2v1MpzSMGgY6fJw+60qQjhrWDwo+Lb6juwPjX3Tr K1Bexmqw== X-Received: by 2002:adf:db8e:0:b0:2fe:f2d1:dcab with SMTP id u14-20020adfdb8e000000b002fef2d1dcabmr12086248wri.58.1683024882356; Tue, 02 May 2023 03:54:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xZ1ZePYWmzl2j4e8+c0huGz+/uvLK8+ixAR3BkDmT5LhsJaHu5vMEt4/vJ548tnXNC/ThqQ== X-Received: by 2002:adf:db8e:0:b0:2fe:f2d1:dcab with SMTP id u14-20020adfdb8e000000b002fef2d1dcabmr12086234wri.58.1683024881960; Tue, 02 May 2023 03:54:41 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id j5-20020a5d6045000000b0030626f69ee7sm7622726wrt.38.2023.05.02.03.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 03:54:41 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: compile gdb.linespec/cp-completion-aliases.exp as C++ Date: Tue, 2 May 2023 11:54:39 +0100 Message-Id: <4e545e3f3d600e62ed6522e0ed6ef609a6fe8354.1683024857.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Noticed in passing that the prepare_for_testing call in gdb.linespec/cp-completion-aliases.exp does not pass the 'c++' flag, despite this being a C++ test. I guess, as the source file has the '.cc' extension, all the compilers are doing the right thing anyway -- the source file uses templates, so is definitely being compiled as C++. I noticed this when I tried to set CXX_FOR_TARGET (but not CC_FOR_TARGET) and spotted that this script was still using the C compiler. Fixed in this commit by adding the 'c++' flag for prepare_for_testing. --- gdb/testsuite/gdb.linespec/cp-completion-aliases.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.linespec/cp-completion-aliases.exp b/gdb/testsuite/gdb.linespec/cp-completion-aliases.exp index 33ad72e6f05..4c3ab7362e9 100644 --- a/gdb/testsuite/gdb.linespec/cp-completion-aliases.exp +++ b/gdb/testsuite/gdb.linespec/cp-completion-aliases.exp @@ -20,7 +20,7 @@ load_lib completion-support.exp standard_testfile .cc -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} { +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { return -1 } base-commit: b2499d8a40a6de13e9bc88b973a730bdf8b9b032 -- 2.25.4