From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by sourceware.org (Postfix) with ESMTPS id 3D2073858D32 for ; Mon, 15 Apr 2024 16:32:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D2073858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D2073858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.73 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713198782; cv=pass; b=otzWQAlOXuotGm0Tm5W9j0ujZb3mwi66fHxLenqb3hkryOimLs+2OebGvKGxT0+ZOnXPrgj8lcvWTf92k5uz0+7nhHqCZ/GTBhQSA6uUVnp9kay8KVakVYCsXRJDFdxZ152T7XMNZlEDG5D1yons5NJxFvlRtmkwF9C+vv3R8tk= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713198782; c=relaxed/simple; bh=0pjR4jIMGGOireb6XTBnUmw4VBwNgs/VU2dRKfJ4Cs4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=oMedjy4m5RJFUjYGlSKVJkCsceclDHymwfnfxwE4112Hk/cbSsutjdEFp/lqEqEJoVTDcgLDEE12s/Xnpb4lRcmH9Urmkfn05WgVzPn0z7Ujv2KDmrFxE9b55E8T3h5e3oOAgWviNtIH2QOaRRjYCT4HCrs2RJMkjTKu9jSjUwc= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kBJAU62Q2YYsXjNTUMGWCMheYJR6ox0PzvGIALJ4He4C2foRhvz8ywSYILYRgYF9PLnUcbwDCYASdKfz4GFTNdNXSsjyJXIUDiIGSlv+5yo5A5x20R7g6L5mVmbRFr4Q9mEfb/n6/u3LbJGCF+naEoiaLEnK118odP+0hiqhl6295v5rfpRlqnDqFhDr5OVd2HeLfqD2mdV2Feru52tEjdX+tfluOx4QbeK0KTfwjq7QLLOYRBea/ucsSXeuZ1WWg8b0o9CW2a5N96qzWkpq6i8aIGvYRdGR+wecV8TRlp9yDdYvjvZl3FK0jonBhzxjk8zCoAiu+72h/vl8nwiiRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjaf9ozYypYN+FPv4PmSyfenS5clrNPCySqJ6pjgVpU=; b=YH86DaVpkc7KWRUXCrxuQSZZ7tQ1sR/1zc27c7FQ5LE8RzgqBBqGuJyDSK25D8gKYc0w32+sloc6j019Qal6xS3asf26hAAn/4wFIFDRH7MMG98t44MUPnbDxPcZvzlBu2X7UVI4dIYqX2ao7ixeV42w2Q3CFvKjMVT7c4XW3a/BtMS11WdrXOg2TNiPVnC5imefsKemK13eFJRR0JPD4xQmT8csUyfkfSYuvoF3zV7dNigwVlovSGtN/a3Q1Pue9iGvqoQOop3i2Sk/C5Nebq6ArhN8BTfcJq8JQ/S4FZjxERlpw1Y6vK5o71le9Jg+ajIcr5ADEJ9jDs0XaYP9CQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjaf9ozYypYN+FPv4PmSyfenS5clrNPCySqJ6pjgVpU=; b=QhrBygUT5NtIYbSilhoJ9pfQbla2tlgNB0Ql+LsAum0+ki/Oq86Xinn57qB/53akl6p6hIS6/nwE9TY3sJVESmrU7nXBmnpM19v2oFKRPjlupNUo68oImrcapL0JO/hdxZ2cg1BIvvW0xiWskv7m9taaQ7G2qgEW3Cw8QW379ws= Received: from DU7P195CA0003.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::19) by GV2PR08MB8341.eurprd08.prod.outlook.com (2603:10a6:150:bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 16:32:47 +0000 Received: from DU2PEPF00028CFE.eurprd03.prod.outlook.com (2603:10a6:10:54d:cafe::8c) by DU7P195CA0003.outlook.office365.com (2603:10a6:10:54d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.33 via Frontend Transport; Mon, 15 Apr 2024 16:32:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028CFE.mail.protection.outlook.com (10.167.242.182) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Mon, 15 Apr 2024 16:32:47 +0000 Received: ("Tessian outbound caed45120527:v313"); Mon, 15 Apr 2024 16:32:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1069da7d57bddb15 X-CR-MTA-TID: 64aa7808 Received: from 695efce0b74f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A40B175E-862B-473B-B03E-C2B7EB50E75F.1; Mon, 15 Apr 2024 16:32:41 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 695efce0b74f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Apr 2024 16:32:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwR+CJt+UETmiwDVJWXxL6ueEuqzhhiAU/XIVH1c4rUxQSypex6QaLayjUThDCnmiO05yMCyle679vIOdfv5D80C3Pwu51F/78QLzB2AeLHCrW+izJO5qkwDElJvlxFbrGPvBZXEgAZqoXzcpX6nLRmBCN4zWRijs3EPCqbeLIcXkf+pP03sl++5jgDcrVUDcVAcWd/fh0UXqg/4xDqzreYiEGDWnGy/ZC7LTiV3eWLF1bBLegw/k8886DHrxSpQq3a0Zgu+h/iuCTzFTIgIjSM2gL6y3pWJV+9pfL5wkV1UQ22QH76ozRDHgJ2BidVQlWDYadcoZHeUtSatMy4eMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjaf9ozYypYN+FPv4PmSyfenS5clrNPCySqJ6pjgVpU=; b=myZzvV6XkRF9c6mf1LG1WJWSwIwMNYLBKPCDYo609EfqD0aJFpIY9/eYV29A1SupvQNYRIItP2M8Lgw+tDPN7l/JihCCZS2zoPpmWoe0XDTLtxPSn50u9UbB9sjXoT8g8ZczzR/UMEhLMfNpfrbicLTnD6ElNGE0LzZuOu9oa+ixvd3njbpdIwK0Z23MKFt4UJx//+0s+CBp1BvI4vqIVH0yJ0iTvBIVBNUJw9DOLO9pzuesf4kpxJ32IGN3+LCLWN2RI3aq905P2i4qd7WYwfLIJyS1/fg15NRDu91hPb0c8V0/6VWLYwmawcqZ7CRdmd4erZxXCMkAIXTIr5Tnpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjaf9ozYypYN+FPv4PmSyfenS5clrNPCySqJ6pjgVpU=; b=QhrBygUT5NtIYbSilhoJ9pfQbla2tlgNB0Ql+LsAum0+ki/Oq86Xinn57qB/53akl6p6hIS6/nwE9TY3sJVESmrU7nXBmnpM19v2oFKRPjlupNUo68oImrcapL0JO/hdxZ2cg1BIvvW0xiWskv7m9taaQ7G2qgEW3Cw8QW379ws= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV1PR08MB7915.eurprd08.prod.outlook.com (2603:10a6:150:8d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 16:32:38 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472%4]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 16:32:35 +0000 Message-ID: <4e81d0b5-0fc7-49de-91d7-956248610a1c@arm.com> Date: Mon, 15 Apr 2024 17:32:33 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension Content-Language: en-US To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240412175200.829114-1-simon.marchi@efficios.com> <87cyqq38b4.fsf@tromey.com> From: Luis Machado In-Reply-To: <87cyqq38b4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0015.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::11) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV1PR08MB7915:EE_|DU2PEPF00028CFE:EE_|GV2PR08MB8341:EE_ X-MS-Office365-Filtering-Correlation-Id: e88d93c6-4078-4aba-0710-08dc5d69af86 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?WE9iRDUrd1RvYUd3MU1tMmxRZy9OdVdIQVlhZFVIcFdpOXlVZHVoSUxwR1Nl?= =?utf-8?B?MjIrd2VmQVZzQTMrK0lmMlhDejlUWTFrWU9NQlc2VHdaMmhPbEhvNG0veFVC?= =?utf-8?B?Y1NLemgwUmhmbURSQ1RxTldiY2JUeXQ4TkVLNkkzZFhBem1KSEluTUpGOXNZ?= =?utf-8?B?bm9TcEptSTNzQnExaDRtRVM2aGt4SnEvcEFMVXlCeWdFRHJoTlJ4akFDMVA0?= =?utf-8?B?QmxlcFJVVTduVEtCSEh5bFB1M2F2YXIvUDhYakppZ2h6eHRLMUVpMkNqZWIx?= =?utf-8?B?emJ6MHZ0bTJ4ZGFqVHl1dGp1aHJVbXhTUkw5R3d2MGJtd3YxdkF3c0JoM0Zt?= =?utf-8?B?U2VvbFFLSjdlaWNFdkZXTVhySCt1NFAwSW12Y3hBc2tUMDBBNGtnNy9tMEpq?= =?utf-8?B?OHVmMzF4Q3NnclY5WTVMMUdLR2ttSnBDMmdJMkxuQmNxQkNjUEdSS0xVUzh4?= =?utf-8?B?V0NHTmh0b253enczNjdodGpWd0dvWE5MY2hIRlp6V3NTaGpBSkhiN0xQTHBu?= =?utf-8?B?OEwyRWdRcUpXRkFRdFgyNjZhZXNMVCttTHRRS2kwUXVyTG04bmE3MnhnUzlB?= =?utf-8?B?Y3QwQXRGcVM1VUhVb3h2ZTFRZUpkODAxWmJSQVpqVU1mRU1iK042YndNTlRj?= =?utf-8?B?bVlnVmhESHJra25BQ3A0dXEra0RBOWQ1V3h1bno4ang3WENUSjF3eUVoWWdv?= =?utf-8?B?NmZFZ2RRV1lwWkQrSXd2RlhBZG41R0p4SUY3QmxtYmFIUS9WeG00YXFSZzEx?= =?utf-8?B?OW9wZC9PRk5NODRXcjUwTWltNTc5aEJDWDJFV1V6K3R5TFJnbTJHbUMxRkU5?= =?utf-8?B?Q0hJaDhzbXh2L0ZmL0FYSjJmc09nVFViWUxnK1czdlo0Ry9iMXpWWnZzQ3Y3?= =?utf-8?B?RjlsU3JtSHFzZ09YcFpKSmE5SlhKL1NONXoxcURCUWl5RTZ6b1NrMEcxQ2NH?= =?utf-8?B?UE4xSExNa3IvNHpJQUZRZmFnR0YzeW9ma3hMUUF3SHd4cm1CN3h2QnRmTHJj?= =?utf-8?B?aWV5b2YzNHVBVHYwTHdZQVhGZk9PUmZmOW5TNGtlcUdqL0g2QjArWmM5KzRP?= =?utf-8?B?RmNZL2l6Umpsbm5aRjgwZzFDUTVBc25hRUVKdzFzaDBtcWpyak9tK3VabE5n?= =?utf-8?B?VWN6U3lxOHc2SDNyZUhOdXlvUFpWaWJ2MitMYW9lQ3dEbGlsTy9sMEorUzlZ?= =?utf-8?B?THFsNGhmay9SeWhNcGdUTVUzdWkxTWxYSThFL0dib0UrTG1pbVpUQ3FTcXFs?= =?utf-8?B?bWFleU91eHBqS3cxRVZPZVRRUWE1aDNzUjliOXdEaXVoMkVWSHc3aHN0TlN1?= =?utf-8?B?OFN4RWZaSmJrNFhqOFRlV2xMRVpvcGFjaCtOOUFyYTBUNUE1cFdjbkJnMTlW?= =?utf-8?B?dzhoQ25jSG5yaHFPb0ZPMk1ENXVuUTZ3bHIrMTNkWmdmRHJZanNNRXJKNUlN?= =?utf-8?B?TTUxVHQ5bFdlTXo4V0tpVVNwRGhGeDFNSFhzbHFhZEhJRUhVcXVHbDIyd2ZF?= =?utf-8?B?Z3hXcjdwVUcrZ3BFMFBtZFJ4T3pJQ0FqanlabnBNMHZsWHY3dHM3WFM4alBP?= =?utf-8?B?aTFYcVpmL3hjYjQrZ0hISHAxVUMwQVVHdDY5UnFTUnMxZHRKOFpKczdjVXU5?= =?utf-8?B?dzRsYXpHTk45dFdZaFBZOG45MllWazNmN0oyWEpYQnUzTkdURllMeXJkV2NG?= =?utf-8?B?VmV2TFZHM1R5RnplSHlYTDRDWHlXVDhkSGt1enVlaE42Qzd1Y2xWcWxnPT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7915 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028CFE.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ac4c3ddf-c028-48aa-fc5d-08dc5d69a851 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9kVrv5Ei55FILCVP+dI83IkGfkpab6xs9Id+LFpo2HNkvJmcoZGFRzFfNmPul7BGu8cG/g5x0r5L8EE9F2vvm/Fx/7JwAQuuA9wPXp76mu/xasPeZBrn4FS9rViOWMilKtdHobOJLJ1wk0eDYntudt6r+jzXvWZHZLg4qwqPaBsAgwhq12uEz22Y2tZQovLgITis6aTqYX06llAsPLsBXFcieoK19g9qw0BlajdN7iARIN8qvwtDzB8nU+r6iP0sbur5OdesV1mSSih1QWGeoTPcIgMqx58dmwk4oAxVIWjhd/jf8TLUklirELsZtAxDsM0KVluELBgzyxqFOn/ufsjh6Saa5LWjHZ/OxOslSdBxisf1NKMTWVGEbZFyFjrxqPxC+DRbDsI/kcg9EqZpyRxzL7W2eTfDaTrRZ8fV7XgrhrFcs8gJaWX+RABB85RwEAx2L2tMktNzkwfGInQ3yWOXlCXHwNHp9VWY364ImvQuZ1Nm5W8Vr8cLljxEWPJMM2jIxamqzcc/85Le2WZla8lQwcVm5W96/gM/hNZCqITLPx05U49JiSnIA/XtNwJlpdyyniZEGiBnhBjEaTuRyohtrd1lHVcxzsf1VI0bHWXyTtW1YSsQQMFmgppdSK0GNUJP/2HLqsnHUe17W12YDjvDhf/wPLhbWv3UBC8Z3nIzGcFGsREjkFK7TMq1SNzqQVpeuxHBiPLGiYJTTOqjP/yItT6qmvlUrb9/6tTj6BoP6SBXB1leARKjWd9vKNf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 16:32:47.7513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e88d93c6-4078-4aba-0710-08dc5d69af86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028CFE.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8341 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/15/24 17:22, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> When building with clang 18, I see: > Simon> CXX aarch64-linux-tdep.o > Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] > Simon> 1299 | gdb_byte za_zeroed[za_bytes]; > Simon> | ^~~~~~~~ > Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: note: read of non-const variable 'za_bytes' is not allowed in a constant expression > Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1282:10: note: declared here > Simon> 1282 | size_t za_bytes = std::pow (sve_vl_from_vg (svg), 2); > Simon> | ^ > > Simon> Since we are using VLAs right now, that warning doesn't make sense for > Simon> us. add `-Wno-vla-cxx-extension` to the list of warning flags we try to > Simon> enable. If we ever choose to disallow VLAs, we can remove that flag. > > I wonder if we should instead remove the use of VLAs. > Is it just the one spot? If we want to go that route, we can modify that code to not use it. I think it was mostly convenience rather than a need for it.