From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id D2E923858D1E for ; Fri, 8 Sep 2023 05:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2E923858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 859E5218E7; Fri, 8 Sep 2023 05:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694152589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAaYhZ8Tzc/FpWokXN/hMzI7XWICC4/29J3TUCoOviw=; b=2MpF7WKgCsYZ2iAAAOIhx4eeAOhhiNTxNFplDG4U4JWGqYtiqXO7OrPtFsGfZojyPj3LEe WBuJn0NCxxpy76qPX4J1S68SeQUUJDAlp2gIiN6pDgo9tTRN6jPkGWcndVnF2x+RvAdFak WMege3TUKYj5xqEBJbrGbKTjZkysGHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694152589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAaYhZ8Tzc/FpWokXN/hMzI7XWICC4/29J3TUCoOviw=; b=3LFWVdbC9nFzPYGx9NOmdupbRLcxPlRl6dYmnTO7s+ANR8NddaIVG/GPzIlVmUQ2miBQC5 yl3cqkb5P/vUBuAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D4C5131FD; Fri, 8 Sep 2023 05:56:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /As6GY23+mTlZAAAMHmgww (envelope-from ); Fri, 08 Sep 2023 05:56:29 +0000 Message-ID: <4e8b46d1-434d-acdf-1db8-55905309f097@suse.de> Date: Fri, 8 Sep 2023 07:56:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/ada] Move identical enums handling later Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230906180121.31694-1-tdevries@suse.de> <87ledim6b8.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87ledim6b8.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/7/23 16:00, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> The problem is here in remove_extra_symbols: > Tom> ... > Tom> if (symbols_are_identical_enums (syms)) > Tom> syms.resize (1); > Tom> ... > Tom> where one of the two identical enums is picked before the enum_rep handling > Tom> can resolve lit3 to one of the two. > > Tom> Fix this by moving the code to ada_resolve_variable. > > Thank you. It's hard to reason about this patch (like, maybe there > could be some code path that now misses the de-duplication), True. > but given > that you tested it, I think it's ok. > Thanks for the review, committed. - Tom > Approved-By: Tom Tromey > > Tom