From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118759 invoked by alias); 1 Jun 2018 12:16:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118506 invoked by uid 89); 1 Jun 2018 12:16:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=PaulKoningdellcom, sk:paul.ko, sk:paulko, sk:PaulKo X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Jun 2018 12:15:43 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C21D97C6B1; Fri, 1 Jun 2018 12:15:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 004141002944; Fri, 1 Jun 2018 12:15:26 +0000 (UTC) Subject: Re: [PATCH] fix build failure with Python 3.7 To: Paul.Koning@dell.com, sergiodj@redhat.com References: <96198491-96D8-42F0-9956-1C2BC9277050@dell.com> <87fu27fux2.fsf@redhat.com> <2BFDF702-C2E4-4339-ABB4-D0655063DE95@dell.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4e99c685-9047-bb84-8ead-ea13d4c202d3@redhat.com> Date: Fri, 01 Jun 2018 12:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <2BFDF702-C2E4-4339-ABB4-D0655063DE95@dell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00008.txt.bz2 On 05/31/2018 09:45 PM, Paul.Koning@dell.com wrote: >>> @@ -1667,6 +1667,14 @@ finalize_python (void *ignore) >>> restore_active_ext_lang (previous_active); >>> } >>> >>> +#ifdef IS_PY3K >>> +PyMODINIT_FUNC >>> +PyInit__gdb (void) >>> +{ >>> + return PyModule_Create (&python_GdbModuleDef); >>> +} >>> +#endif >> >> I think it's a good idea to add a comment to this function. > > I added this (after the #ifdef): > > /* This is called via the PyImport_AppendInittab mechanism called > during initialization, to make the built-in _gdb module known to > Python. */ Can the function be made static? I'm a little surprised to see the function being named "Py...", since that kind of looks like stepping in Python's namespace. Thanks, Pedro Alves