From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97786 invoked by alias); 11 Jun 2018 00:46:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96308 invoked by uid 89); 11 Jun 2018 00:45:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=transferring X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jun 2018 00:45:23 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0B7241E529; Sun, 10 Jun 2018 20:45:13 -0400 (EDT) Subject: Re: [PATCH v2 07/10] Increase gdbsever PBUFSIZ To: Alan Hayward , gdb-patches@sourceware.org Cc: nd@arm.com References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-8-alan.hayward@arm.com> From: Simon Marchi Message-ID: <4f46a069-bbd5-3a6c-5703-91cef4e419cc@simark.ca> Date: Mon, 11 Jun 2018 00:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180606151629.36602-8-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00266.txt.bz2 On 2018-06-06 11:16 AM, Alan Hayward wrote: > PBUFSIZ is no longer big enough for SVE. Increase accordingly. > > 2018-06-06 Alan Hayward > > gdbserver/ > * server.h (PBUFSIZ): Increase size > --- > gdb/gdbserver/server.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h > index 9202df2948..8e197eef8f 100644 > --- a/gdb/gdbserver/server.h > +++ b/gdb/gdbserver/server.h > @@ -113,7 +113,7 @@ extern int in_queued_stop_replies (ptid_t ptid); > /* Buffer sizes for transferring memory, registers, etc. Set to a constant > value to accomodate multiple register formats. This value must be at least > as large as the largest register set supported by gdbserver. */ > -#define PBUFSIZ 16384 > +#define PBUFSIZ 18432 > > /* Definition for an unknown syscall, used basically in error-cases. */ > #define UNKNOWN_SYSCALL (-1) > LGTM, I trust your did your maths correctly :). Simon