From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Victor Leschuk <vleschuk@accesssoftek.com>
Subject: Re: [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]
Date: Wed, 13 Dec 2017 23:03:00 -0000 [thread overview]
Message-ID: <4f4790f6-2eca-00a8-97c6-fc7b368273ba@redhat.com> (raw)
In-Reply-To: <10aa4fac-5924-0620-297c-436f4386fe0b@redhat.com>
On 12/13/2017 10:15 PM, Pedro Alves wrote:
> On 12/13/2017 09:57 PM, Jan Kratochvil wrote:
>>> The .debug_names completely misses its support as it does not even produce
>>> DW_IDX_type_unit.
>>
>> Here you are, could you also verify my regression testing for this patch?
>
> Thanks! I'm testing right away.
Yep, it fixes all regressions compared to .gdb_index.
Please fix the following nits and push:
> + int dwarf5_offset_size () const {
The '{' goes on the next line.
> + /* A helper function that writes a single signatured_type to an
> + debug_names. */
Typo: "to an" => "to a".
OK with those fixed.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-12-13 23:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:55 [PATCH v3 0/5] DWARF-5: .debug_names index Jan Kratochvil
2017-06-19 20:55 ` [PATCH v3 2/5] DWARF-5: .debug_names index producer Jan Kratochvil
2017-06-20 15:19 ` Eli Zaretskii
2017-06-22 18:35 ` [PATCH v3.1 " Jan Kratochvil
2017-06-22 19:18 ` Eli Zaretskii
2017-06-22 20:03 ` [PATCH v3.2 " Jan Kratochvil
2017-12-08 23:51 ` Pedro Alves
2017-12-12 15:38 ` Jan Kratochvil
2017-12-31 3:52 ` Simon Marchi
2017-06-19 20:55 ` [PATCH v3 1/5] cc-with-tweaks.sh: Use gdb-add-index.sh Jan Kratochvil
2017-06-29 19:40 ` Simon Marchi
2017-07-01 15:23 ` [PATCH v3.1 " Jan Kratochvil
2017-12-08 23:43 ` Pedro Alves
2017-06-19 20:56 ` [PATCH v3 3/5] Code cleanup: dwarf2_initialize_objfile return value Jan Kratochvil
2017-12-08 23:52 ` Pedro Alves
2017-12-11 13:04 ` Yao Qi
2017-12-11 13:20 ` Pedro Alves
2017-12-11 14:00 ` Pedro Alves
2017-12-11 15:08 ` [pushed] Unbreak build for non-ELF ports (Re: [PATCH v3 3/5] Code cleanup: dwarf2_initialize_objfile return value) Pedro Alves
2017-06-19 20:56 ` [PATCH v3 4/5] Refactor: Move some generic code out of .gdb_index code Jan Kratochvil
2017-12-08 23:53 ` Pedro Alves
2017-06-19 20:56 ` [PATCH v3 5/5] DWARF-5: .debug_names index consumer Jan Kratochvil
2017-06-28 21:21 ` [PATCH v3.1 " Jan Kratochvil
2017-07-02 14:30 ` [PATCH v3.2 " Jan Kratochvil
2017-12-08 23:59 ` Pedro Alves
2017-12-09 0:07 ` [pushed] Add gdb::hash_enum (Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer) Pedro Alves
2017-12-12 16:52 ` [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer Jan Kratochvil
2017-12-13 21:57 ` [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer] Jan Kratochvil
2017-12-13 22:16 ` Pedro Alves
2017-12-13 23:03 ` Pedro Alves [this message]
2017-12-14 9:03 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4790f6-2eca-00a8-97c6-fc7b368273ba@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=vleschuk@accesssoftek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).