From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: tromey@sourceware.org, gdb-patches@sourceware.org,
"Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
Subject: Re: [review] Handle pending stops from the Windows kernel
Date: Tue, 19 Nov 2019 17:22:00 -0000 [thread overview]
Message-ID: <4f51da38-46eb-269e-001c-c71ce88f469d@redhat.com> (raw)
In-Reply-To: <87eey4x80s.fsf@tromey.com>
On 11/19/19 2:20 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> Pedro> I think you should unwind the PC here, not only when returning the pending
> Pedro> event to GDB core. Consider the case of two threads hitting a breakpoint
> Pedro> at the same time. When that happens, and do you "info threads", you want to
> Pedro> see the PC of all threads pointing at a valid instruction. If you don't
> Pedro> unwind the PC of pending breakpoints, then the threads with pending breakpoints
> Pedro> will have their PC offset by one.
>
> I think I tried this, but I can try again.
Thanks.
>
>>> + if (software_breakpoint_inserted_here_p (regcache->aspace (), pc))
>
> Pedro> Why is software_breakpoint_inserted_here_p needed?
>
> Offsetting the PC did not work without this.
> I tried to document my findings here:
>
> https://sourceware.org/ml/gdb-patches/2019-10/msg00338.html
>
Off hand that doesn't sound right. Linux doesn't do that.
See linux-nat.c:save_stop_reason, in the USE_SIGTRAP_SIGINFO case
(the #else case is probably and hopefully dead by now).
With the software_breakpoint_inserted_here_p check in place, what I imagine
would happen is:
- thread A and B hit a breakpoint
- the event for thread B is left pending
- event for thread A is reported
- user/GDB removes the breakpoint before the event for thread B is processed
- user continues
- windows-nat.c prepares to return the pending event for B
- software_breakpoint_inserted_here_p returns false, so the PC is left unadjusted
- gdb core reports a spurious SIGTRAP, with the PC left unadjusted
- if the inferior is resumed, it starts execution with a bogus PC
Without the check, what should happen, and is the right behavior, is:
- thread A and B hit a breakpoint
- the event for thread B is left pending
- event for thread A is reported
- user/GDB removes the breakpoint before the event for thread B is processed
- user continues
- windows-nat.c prepares to return the pending event for B, adjusts the PC
- gdb core sees a TARGET_STOPPED_BY_SW_BREAKPOINT event, with the PC
already adjusted.
- there's no breakpoint at that address, so gdb re-resumes the inferior
transparently, here, in infrun.c:
/* A delayed software breakpoint event. Ignore the trap. */
if (debug_infrun)
fprintf_unfiltered (gdb_stdlog,
"infrun: delayed software breakpoint "
"trap, ignoring\n");
Basically, this mechanism replaces the old moribund locations heuristic.
> IIRC what happened is that gdb would sometimes resume the inferior with
> wrong PC, causing it to crash. However, I don't really recall, since it
> was a long time ago now. I guess I'll re-do the experiments.
Thanks. I'm mystified.
Pedro Alves
next prev parent reply other threads:[~2019-11-19 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 18:05 Tom Tromey (Code Review)
2019-11-04 14:40 ` Luis Machado (Code Review)
2019-11-14 20:27 ` Pedro Alves
2019-11-19 14:20 ` Tom Tromey
2019-11-19 17:22 ` Pedro Alves [this message]
2019-11-26 17:08 ` Tom Tromey
2019-11-19 1:01 ` Joel Brobecker (Code Review)
2019-11-26 17:16 ` [review v2] " Tom Tromey (Code Review)
2019-11-29 19:08 ` Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f51da38-46eb-269e-001c-c71ce88f469d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gerrit@gnutoolchain-gerrit.osci.io \
--cc=tom@tromey.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).