Re: [PATCH 3/4] Provide access to non SEC_HAS_CONTENTS core file sections

[Keith Seitz <keiths@redhat.com>]

On 3/4/20 4:42 PM, Kevin Buettner wrote:

[snip excellent introduction to the problem]

> What we should be doing is this:
> 
> - Attempt to access core file data for SEC_HAS_CONTENTS sections.
> - Attempt to access executable file data if the above fails.
> - Attempt to access core file data for non SEC_HAS_CONTENTS sections, if
>   both of the above fail.

This is also the path that I was investigating. FWIW, I don't see
anything obviously `wrong' with the contents of the patch, but low-level
target operations are outside where I typically work.

Just one trivial request (again):

> gdb/ChangeLog:
> 

+ PR corefiles/25631

> 	* corelow.c (class core_target): Add new field> 	m_core_no_contents_section_table.
> 	(core_target::core_target): Initialize
> 	m_core_no_contents_section_table.
> 	(core_target::~core_target): Free data structure associated
> 	with m_core_no_contents_section_table.
> 	(core_target::files_info): Print section info associated with
> 	m_core_no_contents_section_table.
> 	(core_target:xfer_partial): Revise TARGET_OBJECT_MEMORY case
> 	to consider the stratum beneath the core target as well as
> 	m_core_no_contents_section_table.

Keith